Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usbus: remove deprecated USBUS_HANDLER_FLAG_TR_FAIL flag #19488

Merged
merged 1 commit into from
Apr 21, 2023
Merged

usbus: remove deprecated USBUS_HANDLER_FLAG_TR_FAIL flag #19488

merged 1 commit into from
Apr 21, 2023

Conversation

dylad
Copy link
Member

@dylad dylad commented Apr 19, 2023

Contribution description

This PR removes the deprecated USBUS_HANDLER_FLAG_TR_FAIL flag.

Testing procedure

CI should be enough.

Issues/PRs references

Was deprecated by #17046

@github-actions github-actions bot added Area: sys Area: System Area: USB Area: Universal Serial Bus labels Apr 19, 2023
@dylad dylad added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 19, 2023
@riot-ci
Copy link

riot-ci commented Apr 19, 2023

Murdock results

✔️ PASSED

b1ffce3 usbus: remove deprecated USBUS_HANDLER_FLAG_TR_FAIL flag

Success Failures Total Runtime
6882 0 6882 09m:11s

Artifacts

@dylad dylad added the Process: removal Integration Process: The PR is removing a deprecated feature or API label Apr 21, 2023
gschorcht
gschorcht approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flag is declared as deprecated since over a year and should be removed already in 2022.07 release.

@gschorcht
Copy link
Contributor

bors merge

bergzand
bergzand approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack,

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 21, 2023

Already running a review

bors bot added a commit that referenced this pull request Apr 21, 2023
@bors @dylad
Merge #19488
16b1e87 
19488: usbus: remove deprecated USBUS_HANDLER_FLAG_TR_FAIL flag r=gschorcht a=dylad

### Contribution description

This PR removes the deprecated `USBUS_HANDLER_FLAG_TR_FAIL` flag.

### Testing procedure

CI should be enough.

### Issues/PRs references

Was deprecated by #17046

Co-authored-by: Dylan Laduranty <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 21, 2023

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

@bors
Copy link
Contributor

bors bot commented Apr 21, 2023

Build succeeded:

@bors bors bot merged commit ca4be42 into RIOT-OS:master Apr 21, 2023
@dylad dylad deleted the pr/usbus/remove_deprecated_flag branch April 21, 2023 15:22
@dylad
Copy link
Member Author

dylad commented Apr 21, 2023

Thanks !

@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschorcht gschorcht gschorcht approved these changes

@bergzand bergzand bergzand approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

Assignees
No one assigned
Labels
Area: sys Area: System Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: removal Integration Process: The PR is removing a deprecated feature or API
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
5 participants
@dylad @riot-ci @gschorcht @bergzand @benpicco