Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/net/grnc/netreg: avoid freeing wild pointers #18951

Merged

Conversation

maribu
Copy link
Member

@maribu maribu commented Nov 22, 2022

Contribution description

When freeing any stale pktsnips from stale messages in the mbox, make sure that the messages actually contains a pktsnip before freeing.

Testing procedure

The test tests/pkg_edhoc_c should no longer crash

Issues/PRs references

Split out of #18949

When freeing any stale pktsnips from stale messages in the mbox, make
sure that the messages actually contains a pktsnip before freeing.
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Nov 22, 2022
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 23, 2022
@riot-ci
Copy link

riot-ci commented Nov 23, 2022

Murdock results

✔️ PASSED

747ee9d sys/net/grnc/netreg: avoid freeing wild pointers

Success Failures Total Runtime
117849 0 117849 01h:53m:51s

Artifacts

@maribu maribu merged commit 74bafdf into RIOT-OS:master Nov 23, 2022
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
@maribu maribu deleted the sys/net/gnrc/netapi/fix-wild-pointer-freeing branch December 5, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants