Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/utensor: fix uninitialized variable #18862

Merged
merged 1 commit into from
Nov 10, 2022
Merged

pkg/utensor: fix uninitialized variable #18862

merged 1 commit into from
Nov 10, 2022

Conversation

maribu
Copy link
Member

@maribu maribu commented Nov 9, 2022

Contribution description

This fixes compilation with modern GCC. (And likely runtime issues...)

Testing procedure

tests/pkg_utensor should still pass.

Issues/PRs references

None

@maribu
pkg/utensor: fix uninitialized variable
70a0e3f 
This fixes compilation with modern GCC. (And likely runtime issues...)
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Nov 9, 2022
@riot-ci
Copy link

riot-ci commented Nov 9, 2022

Murdock results

✔️ PASSED

70a0e3f pkg/utensor: fix uninitialized variable

Success Failures Total Runtime
2002 0 2002 09m:10s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

benpicco
benpicco approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also provide an upstream PR.

@maribu maribu merged commit 6700e91 into RIOT-OS:master Nov 10, 2022
@maribu maribu deleted the pkg/utensor branch November 10, 2022 07:44
@maribu
Copy link
Member Author

maribu commented Nov 10, 2022

Thx :)

@maribu maribu mentioned this pull request Nov 10, 2022
Merged
@maribu
Copy link
Member Author

maribu commented Nov 10, 2022

Backport provided in #18865

@maribu
Copy link
Member Author

maribu commented Nov 10, 2022

Please also provide an upstream PR.

Our package is 2 years behind upstream and the function fixed no longer is present in the upstream repo.

@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.
4 participants
@maribu @riot-ci @benpicco @kaspar030