drivers/usbdev_synopsys_dwc2: small fixes #18759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `usbdev_synopsys_dwc2 driver` requires the `ztimer_msec` module and is therefore responsible for pulling it in.
The `usbdev_synopsys_dwc2 driver` requires the `ztimer_msec` module and is therefore responsible for pulling it in. Therefore, the dependency on `ztimer_msec` can be removed here.
`MODULE_USBDEV_SYNOPSYS_DWC2` depends already on `HAS_PERIPH_USBDEV`.
Since the total USB OTG FIFO size is a hardware propertie, it must not be overridable.
Use `DWC2_USB_OTG_FS_TOTAL_FIFO_SIZE` instead of `USB_OTG_FS_TOTAL_FIFO_SIZE` since the latter is only defined in the vendor headers for STM32 MCUs. The STM32-specific problem that `USB_OTG_FS_TOTAL_FIFO_SIZE` is not defined in the vendor headers for all STM32 families has therefore been moved from the driver to the STM32-specific USB device header.
gschorcht
requested review from
aabadie,
fjmolinas,
DipSwitch and
vincent-d
as code owners
github-actions
bot
added
Area: cpu
gschorcht
added
the
Type: cleanup
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Oct 17, 2022
Murdock results✔️ PASSED 1dfe79f drivers/usbdev_synopsys_dwc2: use DWC2_USB_OTG_FS_TOTAL_FIFO_SIZE
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a spit-off from PR #18756 and provides some fixes for the
usbdev_synopsys_dwc2:usbdev_synopsys_dwc2driver onztimer_msecztimer_msecin ESP32 make filesMODULE_USBDEV_SYNOPSYS_DWC2onHAS_PERIPH_DEVDWC2_USB_OTG_FS_TOTAL_FIFO_SIZEnot overridable for ESP32 SoCsDWC2_USB_OTG_FS_TOTAL_FIFO_SIZEinstead ofUSB_OTG_FS_TOTAL_FIFO_SIZETesting procedure
There are no functional changes. Green CI should be sufficient.
Issues/PRs references
Split-off from PR #18756