examples/lorawan: disable loramac state persistence on EEPROM #17969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code is kept but disabled by default. A comment explains how to avoid issues when enabling it
aabadie
added
Type: bug
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This is an attempt to fix the problem with
examples/loramacraised in the 2022.04 release tests when the EEPROM of a board under test already contains a loramac stack state from a previous user.The proposed fix is to simply disable the use of
periph_eepromby default. This way no previously stored stack state is reloaded and the test should succeed in any case.A comment is added to explain how to reenable that feature and how to avoid the same issues as in the release tests.
Testing procedure
make test-with-configshould work.Issues/PRs references
This is an attempt to fix the LoRaWAN failing release tests: RIOT-OS/Release-Specs#244
Might also fix #17907