Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/gcoap: split client and server implementation #17471

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

maribu
Copy link
Member

@maribu maribu commented Jan 4, 2022

Contribution description

Move client and server side implementations into separate files to
increase readability. Also get rid of a goto.

Testing procedure

The example should still work as before. Some changes in .text are expected, but RAM consumption should stay identical. (For my .bss and .data remain identical and .text grows by 20 bytes for samr21-xpro.)

Issues/PRs references

None

@github-actions github-actions bot added the Area: examples Area: Example Applications label Jan 4, 2022
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Jan 4, 2022
@maribu
Copy link
Member Author

maribu commented Jan 4, 2022

I had to rebase this, as in the meantime some changes were made. But the only relevant to the C code was @chrysn adaption for truncation that I hopefully rebased correctly.

Move client and server side implementations into separate files to
increase readability. Also get rid of a goto.
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

ACK

@aabadie aabadie merged commit df0ac22 into RIOT-OS:master Jan 6, 2022
@maribu
Copy link
Member Author

maribu commented Jan 6, 2022

thx :)

@maribu maribu deleted the examples/gcoap branch January 6, 2022 15:14
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Jan 21, 2022
@miri64 miri64 mentioned this pull request Mar 1, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: examples Area: Example Applications CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants