pkg/umorse: Add kconfig option #15980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrKevinWeiss
added
Type: enhancement
leandrolanzieri
removed
the
CI: ready for build
There was a problem hiding this comment.
You should include the pkg_umorse test application to the ones that murdock tests with Kconfig
Lines 27 to 28 in d7f3e92
With the corresponding app.config.test.
pkg/umorse/Kconfig
Outdated
| # | ||
| config USEPKG_UMORSE | ||
| bool "umorse" | ||
| select USEMODULE_POSIX_SLEEP |
There was a problem hiding this comment.
Suggested change
| select USEMODULE_POSIX_SLEEP | |
| select MODULE_POSIX_SLEEP |
There was a problem hiding this comment.
We should check if it is safe to keep the select or this should be depends on. The posix modules are not modelled AFAIK, so those should be added.
pkg/umorse/Kconfig
Outdated
| # General Public License v2.1. See the file LICENSE in the top level | ||
| # directory for more details. | ||
| # | ||
| config USEPKG_UMORSE |
There was a problem hiding this comment.
Suggested change
| config USEPKG_UMORSE | |
| config PACKAGE_UMORSE |
pkg/umorse/Kconfig
Outdated
| config USEPKG_UMORSE | ||
| bool "umorse" | ||
| select USEMODULE_POSIX_SLEEP | ||
|
|
There was a problem hiding this comment.
Check this new blank line error please.
Add the umorse pkg to the pkg rsource and expose dependancies.
MrKevinWeiss
force-pushed
the
pr/pkg/kconfig
branch
from
e46523d
to
114c6c4
Compare
|
Done and squashed! |
MrKevinWeiss
added
CI: ready for build
|
Don't know why I have 2 of these #15985 |
|
I was confused when I saw this in my MUA and only then I understood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Add the umorse pkg to the pkg rsource and expose dependencies.
Testing procedure
TEST_KCONFIG=1 make menuconfig -C tests/pkg_umorse/Issues/PRs references
Split from #15950