cpu/esp32: increase timeout for spiffs and littlefs tests #12758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
added
Area: cpu
gschorcht
force-pushed
the
cpu/esp32/fix_fs_tests
branch
from
4137a09
to
0b87f4d
Compare
aabadie
reviewed
Nov 20, 2019
aabadie
reviewed
Nov 20, 2019
aabadie
reviewed
Nov 20, 2019
|
@aabadie Many thanks for reviewing 😄 |
17 tasks
The time it takes to erase the entire flash memory of an esp32 card requires increasing the timeout for tests/pkg_spiffs and tests/pkg_littlefs.
gschorcht
force-pushed
the
cpu/esp32/fix_fs_tests
branch
from
330923c
to
47a4ff0
Compare
|
Squashed. |
|
Thanks. |
this changes the timeout to five minutes, which is above the current maximum job length for Murdock. Does it really take that long on the esps? |
|
It takes quite long on ESPs. In contrast to other platforms, these tests use a real SPI flash of 4 MB or more. On ESP8266 it takes about 180 seconds, on ESP32 about 60 seconds, too much for the default timeout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The time it takes to erase the entire flash memory of an ESP32 board requires increasing the timeout for
tests/pkg_spiffsandtests/pkg_littlefs.Fixes the automatic tests of
tests/pkg_spiffsandtests/pkg_littlefsfor ESP32 boards.This PR belongs to the series of PRs, each with very small changes that fix automatic tests on ESP32 boards.
Testing procedure
Make, flash and execute the tests mentioned.
Issues/PRs references
Requires #12752