Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/netstat_l2: workaround for esp32 boards #12756

Closed
wants to merge 2 commits into from
Closed

tests/netstat_l2: workaround for esp32 boards #12756

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edc1706
tests/netstat_l2: remove esp32 boards in netif list
gschorcht Nov 20, 2019
a3e61fb
tests/netstat_l2: settable BOARD_PROVIDES_NETIF
gschorcht Nov 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tests/netstats_l2/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
include ../Makefile.tests_common

BOARD_PROVIDES_NETIF := airfy-beacon fox iotlab-m3 mulle native nrf51dk nrf51dongle \
BOARD_PROVIDES_NETIF ?= airfy-beacon fox iotlab-m3 mulle native nrf51dk nrf51dongle \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use the following:

Suggested change
BOARD_PROVIDES_NETIF ?= airfy-beacon fox iotlab-m3 mulle native nrf51dk nrf51dongle \
BOARD_PROVIDES_NETIF += airfy-beacon fox iotlab-m3 mulle native nrf51dk nrf51dongle \

Not sure if it's useful or not (if not you can ignore).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not make any difference if you specify this variable explicitly for its use with a single board. BTW, netstat_l2 could be used with ESP8266 boards in same way.

nrf6310 pba-d-01-kw2x samd21-xpro saml21-xpro samr21-xpro spark-core \
yunjia-nrf51822 msba2 \
esp32-mh-et-live-minikit esp32-olimex-evb \
esp32-wemos-lolin-d32-pro esp32-wroom-32 esp32-wrover-kit
yunjia-nrf51822 msba2

BOARD_WHITELIST += $(BOARD_PROVIDES_NETIF)

Expand Down