-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
posix_sockets: set read/write permissions for socket fd #11576
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Area: POSIX
Area: POSIX API wrapper
Area: network
Area: Networking
Area: fs
Area: File systems
labels
May 24, 2019
This bug fix should go into the release. |
haukepetersen
approved these changes
Aug 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
haukepetersen
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Aug 1, 2019
all green -> go |
Thanks for the review :-) |
@MrKevinWeiss as you are preparing for a 2019.07.1 release, shall I backport this one? |
Sure we can add it to the list! |
MrKevinWeiss
added
Process: needs backport
Integration Process: The PR is required to be backported to a release or feature branch
Process: release cycle
Integration Process: The PR is connected to the release cycle (e.g. release notes)
labels
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: fs
Area: File systems
Area: network
Area: Networking
Area: POSIX
Area: POSIX API wrapper
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Process: needs backport
Integration Process: The PR is required to be backported to a release or feature branch
Process: release cycle
Integration Process: The PR is connected to the release cycle (e.g. release notes)
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
In #11212 it was discovered, that the permissions for the file descriptors of POSIX sockets are not set so
write
andread
can be used. This fixes that.Testing procedure
Flash and run the application provided in #11212 on 2
samr21-xpro
s. Without this PRecho send
returns "Bad file descriptor" as itswrite()
call ends up hereRIOT/sys/vfs/vfs.c
Lines 325 to 328 in f6ee0ac
Issues/PRs references
Fixes #11212.