Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VERSION: add 2019.04 version file #11455

Merged
merged 1 commit into from
Apr 29, 2019
Merged

VERSION: add 2019.04 version file #11455

merged 1 commit into from
Apr 29, 2019

Conversation

danpetry
Copy link
Contributor

Contribution description

Add version file for release branch

@danpetry danpetry requested review from miri64 and aabadie April 26, 2019 14:50
@miri64
Copy link
Member

miri64 commented Apr 26, 2019

We should merge this after the release note backport.

@miri64 miri64 added Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 26, 2019
@miri64
Copy link
Member

miri64 commented Apr 26, 2019

Please rebase.

@danpetry
Copy link
Contributor Author

I'm just raising a fixup to the release notes to include the failing tests for the frdm-k64f, please hold off :)

@miri64
Copy link
Member

miri64 commented Apr 26, 2019

Due to #11457, another rebase is needed :-/

@danpetry
Copy link
Contributor Author

done

miri64
miri64 approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And ACK

@miri64
Copy link
Member

miri64 commented Apr 29, 2019

And go.

@miri64 miri64 merged commit 7a28e1c into RIOT-OS:2019.04-branch Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

@aabadie aabadie Awaiting requested review from aabadie

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danpetry @miri64