Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serial.inc.mk: disable local echo in picocom. #11062

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

jcarrano
Copy link
Contributor

@jcarrano jcarrano commented Feb 25, 2019

Contribution description

Due to a recent fix in shell.c (#10630), remote echo is now working as originally intended. Local echo must be disabled or otherwise it will add up to the remote one, causing a character-by-character double echoing.

Testing procedure

Note: exit picocom by typing Ctrl-a Ctrl-x.

Run RIOT_TERMINAL=picocom BOARD=samr21-xpro make -C tests/shell term

Without this fix:

Type [C-a] [C-h] to see available commands
Terminal ready


> hheellpp

Command              Description
---------------------------------------
start_test           starts a test
end_test             ends a test
echo                 prints the input command
reboot               Reboot the node
ps                   Prints information about running threads.
> <type enter here>
<empty line that shoul not exist>
>

With this fix:

> help
Command              Description
---------------------------------------
start_test           starts a test
end_test             ends a test
echo                 prints the input command
reboot               Reboot the node
ps                   Prints information about running threads.
>  <note no empty line after typing enter here>
>

Issues/PRs references

See #10630, #10952

@jcarrano jcarrano added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tools Area: Supplementary tools labels Feb 25, 2019
@jcarrano jcarrano requested a review from cladmi February 25, 2019 15:59
@jcarrano jcarrano changed the title serial.inc.mk: disable local echo in minicom. serial.inc.mk: disable local echo in picocom. Feb 25, 2019
@jcarrano jcarrano added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 25, 2019
Due to a recent fix in shell.c, remote echo is now working as originally
intended. Local echo must be disabled or otherwise it will add up to the
remote one, causing a character-by-character double echoing.
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 merged commit 5355f6a into RIOT-OS:master Mar 5, 2019
@danpetry danpetry added this to the Release 2019.04 milestone Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants