serial.inc.mk: disable local echo in picocom. #11062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Due to a recent fix in shell.c (#10630), remote echo is now working as originally intended. Local echo must be disabled or otherwise it will add up to the remote one, causing a character-by-character double echoing.
Testing procedure
Note: exit picocom by typing Ctrl-a Ctrl-x.
Run
RIOT_TERMINAL=picocom BOARD=samr21-xpro make -C tests/shell term
Without this fix:
With this fix:
Issues/PRs references
See #10630, #10952