Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mips: several issues #8052

Closed
5 of 6 tasks
kaspar030 opened this issue Nov 16, 2017 · 7 comments · Fixed by #13125
Closed
5 of 6 tasks

mips: several issues #8052

kaspar030 opened this issue Nov 16, 2017 · 7 comments · Fixed by #13125
Assignees
@neiljay
Labels
Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@kaspar030
Copy link
Contributor

kaspar030 commented Nov 16, 2017 •
edited by aabadie
Loading

Apart from the issues in #6588, there are some more:

  • the mips CPU makefiles have quite a lot of code duplication
  • the mips flash targets are empty. They should fail and explain why ("No flash tool available. See https://..." ...).
  • the mips board wiki-pages lack information on how to flash.
@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: MIPS Platform: This PR/issue effects MIPS-based platforms labels Nov 16, 2017
@neiljay
Copy link
Contributor

neiljay commented Nov 16, 2017

@kaspar030 (and everyone else),

I will attempt to address these issue, but it may take a couple of weeks, things are very busy at the moment, In case you had not heard:

https://www.electronicsweekly.com/news/business/imagination-press-ahead-mips-sale-us-group-tallwood-2017-09/

Neil

@cladmi
Copy link
Contributor

cladmi commented Nov 30, 2017

This PR fixed some of the code duplication in the makefiles: #8032
Some more cleanup can be done by making mips_pic32_common depend on mips32r2_common which would depend on mips.inc.mk.

@jnohlgard
Copy link
Member

jnohlgard commented Dec 8, 2017 •
edited by smlng
Loading

Some more issues popped up:

  • The MIPS CPUs never call the common periph_init during boot as far as I can tell.
  • The MIPS CPUs do not have a cpu_init function which is called by the board_init to initialize things in the CPU, (this function in the other CPUs is sometimes very simple with only a call to periph_init)

neiljay pushed a commit to neiljay/RIOT that referenced this issue Dec 12, 2017
mips: clean up pic32 makefiles.
d70c339 
Make pic32m* depend on pic32_common which depends on mips32r2_common.
Remove some duplication.

This addresses some issues in RIOT-OS#8052.
@neiljay neiljay mentioned this issue Dec 12, 2017
Merged
neiljay pushed a commit to neiljay/RIOT that referenced this issue Dec 12, 2017
mips: clean up pic32 makefiles.
89ababd 
Make pic32m* depend on pic32_common which depends on mips32r2_common.
Remove some duplication.

This addresses some issues in RIOT-OS#8052.
neiljay pushed a commit to neiljay/RIOT that referenced this issue Dec 13, 2017
mips: clean up pic32 makefiles.
4f9a422 
Make pic32m* depend on pic32_common which depends on mips32r2_common.
Remove some duplication.

This addresses some issues in RIOT-OS#8052.
neiljay pushed a commit to neiljay/RIOT that referenced this issue Jan 2, 2018
mips: clean up pic32 makefiles.
72432e2 
Make pic32m* depend on pic32_common which depends on mips32r2_common.
Remove some duplication.

This addresses some issues in RIOT-OS#8052.
neiljay pushed a commit to neiljay/RIOT that referenced this issue Jan 2, 2018
mips: clean up pic32 makefiles.
0133de6 
Make pic32m* depend on pic32_common which depends on mips32r2_common.
Remove some duplication.

This addresses some issues in RIOT-OS#8052.
@neiljay neiljay mentioned this issue Jan 15, 2018
Merged
@neiljay
Copy link
Contributor

neiljay commented Jun 27, 2018

item 2 now resolved in #9259. I think this can be closed ?

@cladmi
Copy link
Contributor

cladmi commented Jun 28, 2018

It is only flashing pic32-wifire and not pic32-clicker, also it is currently not merged :)
But we are getting closer to closing this.

panail pushed a commit to panail/RIOT that referenced this issue Oct 29, 2018
@kaibeckmann
mips: clean up pic32 makefiles.
436c874 
Make pic32m* depend on pic32_common which depends on mips32r2_common.
Remove some duplication.

This addresses some issues in RIOT-OS#8052.
@stale
Copy link

stale bot commented Aug 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@stale stale bot closed this as completed Sep 10, 2019
@kaspar030
Copy link
Contributor Author

This is still being worked on.

@kaspar030 kaspar030 reopened this Sep 10, 2019
@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Sep 10, 2019
@francois-berder francois-berder mentioned this issue Jan 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neiljay neiljay

Labels
Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

boards: pic32-clicker: Use pic32prog as default programmer francois-berder/RIOT
4 participants
@cladmi @jnohlgard @kaspar030 @neiljay