Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cortexm-common: minimal configuration grew by 200 bytes #7575

Closed
miri64 opened this issue Sep 6, 2017 · 2 comments
Closed

cortexm-common: minimal configuration grew by 200 bytes #7575

miri64 opened this issue Sep 6, 2017 · 2 comments
Assignees
Labels
Area: build system Area: Build system Platform: ARM Platform: This PR/issue effects ARM-based platforms State: stale State: The issue / PR has no activity for >185 days Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Comments

@miri64
Copy link
Member

miri64 commented Sep 6, 2017

Checking our minimal configuration I noticed that it grew by 200 bytes (at least on IoT-LAB-M3, for Cortex-M0 boards even more IIRC) since we last checked and documented it (in this case in some paper draft ;-)). After some bisecting I found 4bfce89 to be the commit that significantly made it bigger (though there are others that always made it bigger some bytes). This particular commit unified the periph initialization. Due to that SPI is included, though it isn't really needed. Just another example of our messed-up build system maintenance ;-).

(This is just a note for @haukepetersen, we discussed this already offline)

@miri64 miri64 added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: build system Area: Build system labels Sep 6, 2017
@roberthartung
Copy link
Member

True.. I also came upon the periph_init() call in cpu_init and thought if there was a better solution to this.

@stale
Copy link

stale bot commented Aug 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@stale stale bot closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Platform: ARM Platform: This PR/issue effects ARM-based platforms State: stale State: The issue / PR has no activity for >185 days Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

No branches or pull requests

3 participants