Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ng_ipv6_netif: ng_ipv6_netif_find_best_src_addr() doesn't take mc addresses scope into account #3061

Closed
miri64 opened this issue May 25, 2015 · 3 comments
Closed

ng_ipv6_netif: ng_ipv6_netif_find_best_src_addr() doesn't take mc addresses scope into account #3061

miri64 opened this issue May 25, 2015 · 3 comments
Assignees
@cgundogan
Labels
Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Milestone
Network Stack Tas...

Comments

@miri64
Copy link
Member

miri64 commented May 25, 2015

Multicast addresses have a scope. Among this the link-local scope. ng_ipv6_netif_find_best_src_addr() currently returns just the first fitting unicast address assigned to the interface af the input address is a multicast address and the scope is not taken into account. A fix for that should do that and also consider other prefixes for other multicast scopes.

Marked as minor bug, since we haven't implemented MLD until now and thus only dealing with link-local-only multicast addresses anyways.
@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer NSTF labels May 25, 2015
@miri64 miri64 added this to the Network Stack Task Force milestone May 25, 2015
@miri64 miri64 mentioned this issue May 25, 2015
Merged
@OlegHahm
Copy link
Member

fixed?

@miri64
Copy link
Member Author

miri64 commented May 26, 2015

No.

@OlegHahm
Copy link
Member

Should be fixed by #3561.

@miri64 miri64 added the Area: network Area: Networking label Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgundogan cgundogan

Labels
Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Network Stack Task Force
Development

No branches or pull requests
3 participants
@miri64 @cgundogan @OlegHahm