Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build relic with benchmarks or tests #12897

Open
maksim-pinguin opened this issue Dec 6, 2019 · 3 comments
Open

Can't build relic with benchmarks or tests #12897

maksim-pinguin opened this issue Dec 6, 2019 · 3 comments
Assignees
Labels
Area: pkg Area: External package ports Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@maksim-pinguin
Copy link

maksim-pinguin commented Dec 6, 2019

I was trying to build riot with the relic library with the BENCH and the TESTS flag set.
The build failed with the following error when at least one of the flags(BENCH,TEST) is set to a value above zero.
This is the error it produces
with BENCH flag set:
[ 88%] Linking C executable ../bin/bench_rand gcc: error: gcc: No such file or directory make[4]: *** [bench/CMakeFiles/bench_rand.dir/build.make:85: bin/bench_rand] Error 1 make[3]: *** [CMakeFiles/Makefile2:229: bench/CMakeFiles/bench_rand.dir/all] Error 2 make[2]: *** [Makefile:130: all] Error 2 make[1]: *** [Makefile:16: all] Error 2 make: *** [/home/maksim/code/RIOT/examples/Relic_Hello-World/../../Makefile.include:614: pkg-build-relic] Error 2
with TESTS flag set:
[ 85%] Building C object test/CMakeFiles/test_ec.dir/test_ec.c.obj [ 86%] Linking C executable ../bin/test_ec gcc: error: gcc: No such file or directory make[4]: *** [test/CMakeFiles/test_ec.dir/build.make:85: bin/test_ec] Error 1 make[3]: *** [CMakeFiles/Makefile2:233: test/CMakeFiles/test_ec.dir/all] Error 2 make[2]: *** [Makefile:141: all] Error 2 make[1]: *** [Makefile:16: all] Error 2 make: *** [/home/maksim/code/RIOT/examples/Relic_Hello-World/../../Makefile.include:614: pkg-build-relic] Error 2 [maksim@maksbook ~/code/RIOT/examples/Relic_Hello-World]$

Steps to reproduce:
To build I copied the hello-world example and changed the Makefile
I just added those two lines:

export RELIC_CONFIG_FLAGS=-DARCH=x86 -DQUIET=off -DWORD=32 -DFP_PRIME=255 -DWITH=ALL -DSEED=ZERO -DBENCH=** -DTESTS=**
USEPKG += relic

with -DBENCH and -DTESTS > 0

I'm very new to RIOT so please excuse naivety. By any means I'm ready to solve this problem on my own, but I don't know how to approach right now.

@aabadie
Copy link
Contributor

aabadie commented Jan 3, 2020

Sorry for the late reply.

I don't think using BENCH and TESTS > 0 is supported. In the current state they are forced to 0.

RIOT/pkg/relic/Makefile

Lines 26 to 27 in e45dc52

cmake -DCMAKE_TOOLCHAIN_FILE=$(TOOLCHAIN_FILE) \
-DCHECK=off -DTESTS=0 -DBENCH=0 -DSHLIB=off -Wno-dev $(RELIC_CONFIG_FLAGS) .

Why do need to change these values ?

@aabadie aabadie added the Area: pkg Area: External package ports label Jan 3, 2020
@maksim-pinguin
Copy link
Author

Why do need to change these values ?
I would like to make some benchmarks for performance tests

Is there any chance that it will be supported in near feature?
Would it be hard to implement support? I would try myself but I really don't know how to approach that.

@PeterKietzmann
Copy link
Member

For reference: relic-toolkit/relic#122

@miri64 miri64 added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Jul 6, 2020
@miri64 miri64 added this to the Release 2020.07 milestone Jul 6, 2020
@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: pkg Area: External package ports Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

No branches or pull requests

6 participants