Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_tftp: use of uninitialized values #11772

Closed
nmeum opened this issue Jul 1, 2019 · 1 comment · Fixed by #11773 or #11786
Closed

gnrc_tftp: use of uninitialized values #11772

nmeum opened this issue Jul 1, 2019 · 1 comment · Fixed by #11773 or #11786

Comments

@nmeum
Copy link
Member

nmeum commented Jul 1, 2019

Description

The gnrc_tftp_server doesn't initialize all members of the tftp_context_t in gnrc_tftp_server causing an access of ununinitialised values when receiving messages in an unexpected order.

Steps to reproduce the issue

  1. Build examples/gnrc_tftp with make all-valgrind
  2. Run the application using make term-valgrind
  3. Start the TFTP server using tftps start and wait until it started
  4. Send a DATA tftp packet to the server, for example:
echo AAMAAGZvb2Jhcg== | base64 -d | nc -u '[ip-address%tap0]' 69

Expected results

Valgrind shouldn't report any accesses of uninitialised values.

Actual results

Valgrind reports various conditional jumps or moves which depend on uninitialised values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants