Skip to content

Commit

Permalink
Merge #19299 #19301
Browse files Browse the repository at this point in the history
19299: Add missing newline to output of telnet example r=benpicco a=Enoch247

### Contribution description

From the commit msg:

> The telnet example prints a line to the console, but it is not ended with a newline. When using pyterm, the last line is then never shown as it reads the console line by line and is waiting for the end of the line.
> 
> This patch swaps use of `printf` for `puts` for the last line printed. This means the missing newline character gets added. This is also done to be consistent with the rest of the file, where puts is used whenever possible instead of printf.


### Testing procedure

1. `cd examples/telnet`
2. `make all flash term`
3. observe the final line "Local shell disabled" is printed, but would not have without this patch


### Issues/PRs references

- none known


19301: fib: document unused state r=benpicco a=benpicco



Co-authored-by: Joshua DeWeese <[email protected]>
Co-authored-by: Benjamin Valentin <[email protected]>
  • Loading branch information
3 people authored Feb 22, 2023
3 parents e738fdd + cdf26c9 + 378e5e2 commit 0cce1bc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion examples/telnet_server/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ int main(void)

/* start shell */
printf("All up, awaiting connection on port %u\n", CONFIG_TELNET_PORT);
printf("Local shell disabled");
puts("Local shell disabled");
char line_buf[SHELL_DEFAULT_BUFSIZE];
shell_run(NULL, line_buf, SHELL_DEFAULT_BUFSIZE);

Expand Down
2 changes: 2 additions & 0 deletions sys/include/net/fib.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
* @ingroup net
* @brief FIB implementation
*
* This module is unused by RIOT's networking stacks, see @ref net_gnrc_ipv6_nib_ft
* instead.
* @{
*
* @file
Expand Down

0 comments on commit 0cce1bc

Please sign in to comment.