Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report a notapplicable rule if it fails remediation #33

Open
comps opened this issue Jul 20, 2023 · 1 comment
Open

Report a notapplicable rule if it fails remediation #33

comps opened this issue Jul 20, 2023 · 1 comment

Comments

@comps
Copy link
Contributor

comps commented Jul 20, 2023

For oscap-based remediations, record somewhere on disk (from the oscap ... --remediate output or from a separate preceding read-only oscap scan) which rules resulted in notapplicable (and some similar other statuses?).

When doing waiving during a final scan, report (in a note) that the rule was originally notapplicable, ie.

FAIL /hardening/oscap/stig/postfix_prevent_unrestricted_relay (notapplicable during remediation)

This makes it possible to easily detect & waive rule dependency and ordering issues.

They shouldn't be auto-waived because a failure might not always be due to ordering - a manual re-run to identify if the rule failed after a double remediation should be still done.

@comps
Copy link
Contributor Author

comps commented Jul 20, 2023

This probably slots into #24 in that we ultimately shouldn't report results in real-time from the output of oscap --verbose, but should instead parse a generated results-arf.xml to get more context for the result (remediation shell output, detailed probe findings, etc.).

In a similar case to #24, notapplicable-during-remediation can be another piece of metadata from which a final result (for the one rule) is formed and reported after all testing is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant