Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move exporter code into crane #50

Closed
6 of 8 tasks
dmartinol opened this issue Feb 15, 2023 · 5 comments · Fixed by #64
Closed
6 of 8 tasks

Move exporter code into crane #50

dmartinol opened this issue Feb 15, 2023 · 5 comments · Fixed by #64
Assignees
Milestone

Comments

@dmartinol
Copy link
Collaborator

dmartinol commented Feb 15, 2023

Develop configurable crane plugin(s) to export the same kustomize package that is today generated by the Golang app

  • create issue in crane repository
  • discuss implementation with project contributors
  • develop changes
  • PR
  • merge
  • generate new release
  • remove implementation from Saasi exporter
  • validate changes
@dmartinol
Copy link
Collaborator Author

Started discussion on slack channel

@dmartinol dmartinol self-assigned this Feb 27, 2023
@dmartinol
Copy link
Collaborator Author

Prepared code changes on forked repo:
migtools/crane@main...dmartinol:crane:#148-cluster-scoped-rbac

Waiting approval from contributors to move on with the PR

@dmartinol
Copy link
Collaborator Author

Created code changes for Saasi in related branch:
main...50-move-exporter-code-into-crane

Note: it assumes to have the before mentioned cluster-scoped-rbac feature in crane export, otherwise it would not work

@dmartinol
Copy link
Collaborator Author

PR in crane repository:
migtools/crane#149

Agreed with other contributors to track another issue to clarify that, even if the filtering logic implemented there would be more suitable for the transform step instead of the export one, the current limitations of the tool would lead to very low performance, so for now we accept the change and track the possible enhancement

@dmartinol
Copy link
Collaborator Author

PR in SaaSi:
#64

@dmartinol dmartinol linked a pull request Mar 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants