Skip to content
This repository has been archived by the owner on Dec 9, 2023. It is now read-only.

Expose import_asset, export_asset and list_assets methods #117

Closed
zoedberg opened this issue Dec 5, 2020 · 6 comments · Fixed by RGB-WG/rgb-sdk#31 or #120
Closed

Expose import_asset, export_asset and list_assets methods #117

zoedberg opened this issue Dec 5, 2020 · 6 comments · Fixed by RGB-WG/rgb-sdk#31 or #120
Labels
enhancement Improvement to existing functionality or refactoring
Milestone

Comments

@zoedberg
Copy link
Contributor

zoedberg commented Dec 5, 2020

let's add to the i9n module the methods:

@dr-orlovsky please correct me if I'm wrong

@dr-orlovsky
Copy link
Member

That's right, and list method as well

@dr-orlovsky dr-orlovsky added the enhancement Improvement to existing functionality or refactoring label Dec 5, 2020
@dr-orlovsky dr-orlovsky added this to the v0.2 milestone Dec 5, 2020
@zoedberg zoedberg changed the title Expose import_asset and invoice methods Expose import_asset and list_assets methods Dec 7, 2020
@dr-orlovsky
Copy link
Member

dr-orlovsky commented Dec 9, 2020

Seems like this issue is a blocking and a priority for v0.2 release. @zoedberg will you try to implement the methods or should I work on it myself?

@zoedberg
Copy link
Contributor Author

zoedberg commented Dec 9, 2020

Currently working on RGB-WG/rgb-sdk#24 and RGB-WG/rgb-sdk#29, but I can temporarily pause those to do this.
Actually I've already started working on this some days ago, then encountered some obstacles (while updating the issue call params on the sdk, task required to switch to latest rgb-node release) and so I paused the job. If you want to do this task, I can push my intermediate results so you already have something to start from

@dr-orlovsky
Copy link
Member

I can do the stuff quick, but I thought you are interested in trying to play with the Node code, not just SDK around it, and this may be a good first issue. Your WIP PR will be in any way useful

@zoedberg
Copy link
Contributor Author

zoedberg commented Dec 9, 2020

I am interested, but currently a bit overloaded by tasks. I will give it another try tomorrow, and if not succeed quickly, I'll open a draft PR

@dr-orlovsky
Copy link
Member

Yeah, feel free to postpone other tasks, they are not that critical to do the release

@zoedberg zoedberg changed the title Expose import_asset and list_assets methods Expose import_asset, export_asset and list_assets methods Dec 12, 2020
@dr-orlovsky dr-orlovsky linked a pull request Dec 15, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement to existing functionality or refactoring
Projects
None yet
2 participants