Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature align - multiple peaks undefined behaviour #144

Closed
xtrojak opened this issue Aug 26, 2022 · 0 comments · Fixed by #221
Closed

Feature align - multiple peaks undefined behaviour #144

xtrojak opened this issue Aug 26, 2022 · 0 comments · Fixed by #221
Assignees
Labels
bug Something isn't working

Comments

@xtrojak
Copy link

xtrojak commented Aug 26, 2022

With #88, we unintentionally changed behaviour of feature.align. It concerns this part, that was changed to this part.

Basically, before in a loop a variable was always overwritten and the value from last iteration was taken. In new version, the usage of return statement in the for loop takes value from the first iteration. The tests did not discover this, probably because density function has mostly Gaussian shape with one peak, so it has no effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants