Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing reference to file which is not defined in Python 3 #36

Closed
wants to merge 1 commit into from
Closed

Removing reference to file which is not defined in Python 3 #36

wants to merge 1 commit into from

Conversation

mwatts15
Copy link

@iherman
Copy link
Contributor

iherman commented Mar 22, 2022

(Sorry to be late with this, @mwatts15, I do not really maintain this software any more...

The problem is that the package is used at places that still use python2. Legacy software and all that. Ie, the changes you propose may not work. What about

		if (PY3 and isinstance(input, str)) or (isinstance(input, StringIO) or isinstance(input, file)) :
			parse = xml.dom.minidom.parse
		else:
			parse = xml.dom.minidom.parseString

instead?

(I can make edit the library directly or you can amend the PR; as you prefer)

Thanks

iherman added a commit that referenced this pull request Mar 23, 2022
@iherman
Proposed alternative to PR #36
d1c4791
@iherman iherman mentioned this pull request Mar 23, 2022
Merged
@iherman
Copy link
Contributor

iherman commented Mar 29, 2022

Closing without merge, per #39 which solved it.

@iherman iherman closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing documentation
2 participants
@mwatts15 @iherman