Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyshacl and rdflib 6.0 #92

Closed
satra opened this issue Aug 20, 2021 · 5 comments
Closed

pyshacl and rdflib 6.0 #92

satra opened this issue Aug 20, 2021 · 5 comments

Comments

@satra
Copy link

satra commented Aug 20, 2021

on conda forge (https://github.com/conda-forge/pyshacl-feedstock/pulls), pyshacl is not passing tests, likely because of changes in rdflib 6.0.

    def test_079():
        shape_g = rdflib.Graph().parse(data=shapes_data, format='turtle')
>       print(shape_g.serialize(format="turtle").decode())
E       AttributeError: 'str' object has no attribute 'decode'
@ashleysommer
Copy link
Collaborator

Hi @satra
Thanks for pointing this out. Since v0.15.0 on July 20th, PySHACL was already fully compatible with RDFLib 6.0. Unfortunately I recently committed test_079 code to the repository, which was from a different codebase and did not contain the RDFLib 6.0 update.
I'll rectify that now.

@ashleysommer
Copy link
Collaborator

That is fixed now. Do I need to push a new release for Conda to ingest the new version?

@satra
Copy link
Author

satra commented Aug 21, 2021

Do I need to push a new release for Conda to ingest the new version?

yes, and that will trigger a new PR, which we can then merge.

@ashleysommer
Copy link
Collaborator

@satra
I've pushed a v0.16.1.post1 release which should fix this

@satra
Copy link
Author

satra commented Aug 28, 2021

thanks @ashleysommer - i believe this has been released now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants