Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise to make fewer S3 API calls #543

Open
yatharthranjan opened this issue Feb 8, 2023 · 1 comment
Open

Optimise to make fewer S3 API calls #543

yatharthranjan opened this issue Feb 8, 2023 · 1 comment

Comments

@yatharthranjan
Copy link
Member

it could be optimised by -

  1. not rescanning the full directory hierarchy to find new topics, but limiting that to once per 15 minutes (configurable).
  2. storing the actual file directories (partition=0, etc) to check for updates, instead of the one level above the file directory. Right now only the topic directory is stored.
  3. Keeping in memory the last object that was scanned. Then do not list all files but only newly added files using ListObjectsV2.start-after. Note that you will still want to do a full scan sometimes to avoid files being skipped that were added at a later time or not deemed complete by the cleaner.
@keyvaann
Copy link

@blootsvoets if you had time could you have a look here to see if there is an easy way to reduce S3 api calls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants