From 1b7c6eab12347b6e64d52684b1a14fbadfcbcbd4 Mon Sep 17 00:00:00 2001 From: Humair Khan Date: Fri, 6 Sep 2024 15:25:17 -0400 Subject: [PATCH] (fix): reduce executor logs (#11169) * remove driver logs from executor These logs congest the executor runtime logs making it difficult for the user to differentiate between logs. The driver logs are unnecessary here and can be removed to reduce this clutter. Signed-off-by: Humair Khan * remove duplicate emissary call in executor As per the initial inline dev comment, argo podspecpatch did not add the emissary call, and had to be manualy added. This was fixed a couple of argo versions back. However, as a result executor pod makes double calls to the executor, which as a consequence also results in superflous logs. This change removes the additional call to emissary to resolve this. Signed-off-by: Humair Khan --------- Signed-off-by: Humair Khan --- backend/src/v2/component/launcher_v2.go | 1 - backend/src/v2/driver/driver.go | 3 --- 2 files changed, 4 deletions(-) diff --git a/backend/src/v2/component/launcher_v2.go b/backend/src/v2/component/launcher_v2.go index 2d9b569b8988..2b5297c7b09c 100644 --- a/backend/src/v2/component/launcher_v2.go +++ b/backend/src/v2/component/launcher_v2.go @@ -87,7 +87,6 @@ func NewLauncherV2(ctx context.Context, executionID int64, executorInputJSON, co if err != nil { return nil, fmt.Errorf("failed to unmarshal executor input: %w", err) } - glog.Infof("input ComponentSpec:%s\n", prettyPrint(componentSpecJSON)) component := &pipelinespec.ComponentSpec{} err = protojson.Unmarshal([]byte(componentSpecJSON), component) if err != nil { diff --git a/backend/src/v2/driver/driver.go b/backend/src/v2/driver/driver.go index 56fb45b96f4a..aeeda9b6a48d 100644 --- a/backend/src/v2/driver/driver.go +++ b/backend/src/v2/driver/driver.go @@ -387,9 +387,6 @@ func initPodSpecPatch( userCmdArgs = append(userCmdArgs, container.Command...) userCmdArgs = append(userCmdArgs, container.Args...) launcherCmd := []string{ - // TODO(Bobgy): workaround argo emissary executor bug, after we upgrade to an argo version with the bug fix, we can remove the following line. - // Reference: https://github.com/argoproj/argo-workflows/issues/7406 - "/var/run/argo/argoexec", "emissary", "--", component.KFPLauncherPath, // TODO(Bobgy): no need to pass pipeline_name and run_id, these info can be fetched via pipeline context and pipeline run context which have been created by root DAG driver. "--pipeline_name", pipelineName,