Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞] optimizer generating wrong paths when moving components to new files #5367

Closed
wmertens opened this issue Oct 30, 2023 · 1 comment
Closed
Labels
COMP: optimizer TYPE: bug Something isn't working WAITING FOR: team Waiting for one of the core team members to review and reply

Comments

@wmertens
Copy link
Member

Which component is affected?

Qwik Optimizer (rust)

Describe the bug

See qwikifiers/qwik-ui#453, wmertens/styled-vanilla-extract#23 and #5233

The optimizer creates a new file with components, and any imports are sometimes adjusted, but the adjusting doesn't seem to happen correctly.

Reproduction

see the mentioned issues

Steps to reproduce

import qwik components from a library, make sure these components import relative dependencies as well (in pnpm this includes deps that are only visible to that library).

System Info

happens in latest, perhaps it works with v1.1 before the optimizer rewrite?

Additional Information

No response

@wmertens wmertens added TYPE: bug Something isn't working STATUS-1: needs triage New issue which needs to be triaged COMP: optimizer WAITING FOR: team Waiting for one of the core team members to review and reply P2: important and removed STATUS-1: needs triage New issue which needs to be triaged labels Oct 30, 2023
@mhevery
Copy link
Contributor

mhevery commented Oct 31, 2023

I believe this is a duplicate of #5368 and was resolved in #5368 and can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: optimizer TYPE: bug Something isn't working WAITING FOR: team Waiting for one of the core team members to review and reply
Projects
None yet
Development

No branches or pull requests

2 participants