-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐞] Missing code
property on QwikKeyboardEvent
#5189
Comments
Can you provide more context.... |
Sure, here is the interface for export declare interface QwikKeyboardEvent<T = Element> extends SyntheticEvent<T, NativeKeyboardEvent> {
isComposing: boolean;
altKey: boolean;
charCode: number;
ctrlKey: boolean;
getModifierState(key: string): boolean;
key: string;
keyCode: number;
locale: string;
location: number;
metaKey: boolean;
repeat: boolean;
shiftKey: boolean;
which: number;
} And here is the interface for the native
As you can see the You may also consider deprecating legacy properties like |
Accidentally closed the issue. |
Ohh I see.... Yes, any chance we could get you to create a PR with a fix? |
Sure, I’ll take care of it. |
Thanks 😉 |
Which component is affected?
Qwik Runtime
Describe the bug
The
code
property is missing onQwikKeyboardEvent
, I believe this is an oversight.Reproduction
No reponse
Steps to reproduce
No response
System Info
No response
Additional Information
No response
The text was updated successfully, but these errors were encountered: