Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make loadScriptsOnMainThread accept regexp or substrings #263

Closed
DzmVasileusky opened this issue Sep 23, 2022 · 4 comments · Fixed by #520
Closed

Make loadScriptsOnMainThread accept regexp or substrings #263

DzmVasileusky opened this issue Sep 23, 2022 · 4 comments · Fixed by #520

Comments

@DzmVasileusky
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Current loadScriptsOnMainThread implementation requires 100% match to the url.
But sometimes url is dynamic:

  • it can have different protocols
  • it can use reverse proxy
  • it can have dynamic query string
  • we can have multiple 3rd party scripts and want to block all of them by a domain name or pattern

Describe the solution you'd like
loadScriptsOnMainThread should accept a substring or regexp to allow it working with dynamic / multiple urls

@itxch
Copy link
Contributor

itxch commented Oct 1, 2022

I'd be happy to try implementing this :)

@ramirezcgn
Copy link

I need this feature too.

@gerardo-rodriguez
Copy link

This would be very helpful, thank you! 🙂

@gioboa
Copy link
Member

gioboa commented Jan 7, 2024

Closed by #520

@gioboa gioboa closed this as completed Jan 7, 2024
@gioboa gioboa linked a pull request Jan 7, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants