MC-259583 - Last potion ingredient is deleted.

[OroArmor]

We supposedly fix https://bugs.mojang.com/browse/MC-259583 but it appears to not be so. This is a problem and leads to item deletion.

See also: FabricMC/fabric#2873.

Locations to look:

quilt-standard-libraries/library/item/item_setting/src/main/java/org/quiltmc/qsl/item/setting/mixin/recipe_remainder/BrewingStandBlockEntityMixin.java

Lines 40 to 54 in 009a672

	@Redirect(method = "craft(Lnet/minecraft/world/World;Lnet/minecraft/util/math/BlockPos;Lnet/minecraft/util/collection/DefaultedList;)V",
	at = @At(value = "INVOKE", target = "Lnet/minecraft/item/ItemStack;decrement(I)V")
	)
	private static void applyRecipeRemainder(ItemStack ingredient, int amount, World world, BlockPos pos, DefaultedList<ItemStack> inventory) {
	RecipeRemainderLogicHandler.handleRemainderForNonPlayerCraft(
	ingredient,
	amount,
	null,
	RecipeRemainderLocation.POTION_ADDITION,
	inventory,
	INGREDIENT_SLOT,
	world,
	pos
	);
	}

quilt-standard-libraries/library/item/item_setting/src/main/java/org/quiltmc/qsl/item/setting/mixin/recipe_remainder/ItemsMixin.java

Lines 45 to 51 in 009a672

	private static Item.Settings changeDragonBreathRecipeRemainder(Item.Settings instance, Item recipeRemainder) {
	// See: https://github.com/FabricMC/fabric/issues/2873
	// https://bugs.mojang.com/browse/MC-259583
	return new QuiltItemSettings()
	.recipeRemainder((_original, _recipe) -> recipeRemainder.getDefaultStack())
	.recipeRemainder((original, recipe) -> original.getCount() >= 2 ? recipeRemainder.getDefaultStack() : ItemStack.EMPTY, RecipeRemainderLocation.POTION_ADDITION);
	}

[maloryware]

Is it worth fixing this behavior? Looking at the Fabric issue, this would mean losing vanilla parity and possibly breaking automated potion crafting farms.