Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy Editor: Improve UX when user tries to add # comments #9682

Open
GammaSQ opened this issue Jan 3, 2025 · 0 comments
Open

Policy Editor: Improve UX when user tries to add # comments #9682

GammaSQ opened this issue Jan 3, 2025 · 0 comments
Labels
C: manager/widget P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. ux User experience

Comments

@GammaSQ
Copy link

GammaSQ commented Jan 3, 2025

How to file a helpful issue

Qubes OS release

4.2

Brief summary

When trying to disable a rule with a target (replacing allow with deny), commenting the target (putting a # in front of it) gives the error: "Invalid parameters for action Deny: ['#target=anothervm']"

Expected behavior

Comments at the end of lines are supported.

Or, if this is undesirable for psychological reasons (I could imagine "one line should always be a valid policy"), the error should be highly visible, maybe directly address the invalidity of comments.

Actual behavior

Currently, the comment is tinted blue like other valid comments and Errors are displayed in the exact same style as the "Policy file syntax" Text-wall in the right panel. (in fact it looks even smaller)
The Save Changes buttons look like they are disabled for no reason.

I would not have guessed the Error-message is an important blocker until I carefully searched for reasons why the "save changes" button was disabled. some red color or warning-icons would be helpful.

@GammaSQ GammaSQ added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Jan 3, 2025
@andrewdavidwong andrewdavidwong added T: enhancement C: manager/widget ux User experience and removed T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Jan 3, 2025
@andrewdavidwong andrewdavidwong changed the title Policy Editor does not allow comments at the end of policy Policy Editor: Improve UX when user tries to add # comments Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: manager/widget P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. ux User experience
Projects
None yet
Development

No branches or pull requests

2 participants