Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution cropping does not work with screen sharing #9523

Open
smcgu opened this issue Oct 21, 2024 · 1 comment
Open

Resolution cropping does not work with screen sharing #9523

smcgu opened this issue Oct 21, 2024 · 1 comment
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: Qubes Video Companion diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@smcgu
Copy link

smcgu commented Oct 21, 2024

Problem

Requesting a smaller screen resolution fails to crop the screen video stream. The screenshare will stream at the desktop's normal resolution. The desire is to share a cropped version of the desktop screen to reduce whitespace and improve visibility to stream recipients on the conference call.

Example trying to screenshare at cropped 1920x1080:

$ qubes-video-companion screenshare --resolution=1920×1080x30

(screenshare.py:3217): Gdk-CRITICAL **: 11:22:12.244: gdk_window_thaw_toplevel_updates: assertion 'window->update_and_descendants_freeze_count > 0' failed
/usr/share/qubes-video-companion/sender/screenshare.py:128: DeprecationWarning: Gdk.Screen.width is deprecated
  "crop_r": screen.width()  - geometry.x - geometry.width,
/usr/share/qubes-video-companion/sender/screenshare.py:129: DeprecationWarning: Gdk.Screen.height is deprecated
  "crop_b": screen.height() - geometry.y - geometry.height,
Receiving video stream at 2560x1440 30 FPS...

System Info

OS: Debian 12
Kernel: 6.6.48-1.qubes.fc37.x86_64

qubes-video-companion/unknown,now 1.1.3-1+deb12u1 all [installed]
  Securely stream webcams and share screens across virtual machines

v4l-utils/stable,now 1.22.1-5+b2 amd64 [installed,automatic]
  Collection of command line video4linux utilities

v4l2loopback-dkms/stable,now 0.12.7-2 all [installed,automatic]
  Source for the v4l2loopback driver (DKMS)

v4l2loopback-utils/stable,now 0.12.7-2 all [installed]
  Commandline utilities for the for the v4l2-loopback module
@marmarek marmarek transferred this issue from QubesOS/qubes-video-companion Oct 21, 2024
@marmarek
Copy link
Member

This is expected, the resolution option is intended for webcam target only. The missing part is refusing this option for screenshare action...

@andrewdavidwong andrewdavidwong changed the title Screenshare resolution cropping does not work Refuse cropping action for screen sharing action Oct 22, 2024
@andrewdavidwong andrewdavidwong changed the title Refuse cropping action for screen sharing action qubes-video-companion: Refuse cropping action for screen sharing action Oct 22, 2024
@andrewdavidwong andrewdavidwong added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: other diagnosed Technical diagnosis has been performed (see issue comments). affects-4.2 This issue affects Qubes OS 4.2. labels Oct 22, 2024
@andrewdavidwong andrewdavidwong changed the title qubes-video-companion: Refuse cropping action for screen sharing action qubes-video-companion: Resolution cropping does not work with screen sharing Oct 22, 2024
@andrewdavidwong andrewdavidwong added the P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. label Oct 22, 2024
@andrewdavidwong andrewdavidwong changed the title qubes-video-companion: Resolution cropping does not work with screen sharing Resolution cropping does not work with screen sharing Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: Qubes Video Companion diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

No branches or pull requests

3 participants