broken qvm-device symlinks

[ethnh]

The problem you're addressing (if any)

broken qvm-device symlinks

The solution you'd like

From dadc0d427eddaf49a6b213e7345c86e81a9c84e7 Mon Sep 17 00:00:00 2001
From: Yaroslav Bolyukin <[email protected]>
Date: Mon, 16 Sep 2024 18:54:05 +0200
Subject: [PATCH 2/6] fix: broken qvm-device symlinks

---
 Makefile | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/Makefile b/Makefile
index 7a410ade..89cc36fc 100644
--- a/Makefile
+++ b/Makefile
@@ -179,13 +179,7 @@ ifeq ($(OS),Linux)
 	$(MAKE) install -C linux/system-config
 endif
 	$(PYTHON) setup.py install -O1 --skip-build --root $(DESTDIR)
-	ln -sf qvm-device $(DESTDIR)/usr/bin/qvm-block
-	ln -sf qvm-device $(DESTDIR)/usr/bin/qvm-pci
-	ln -sf qvm-device $(DESTDIR)/usr/bin/qvm-usb
-	install -d $(DESTDIR)/usr/share/man/man1
-	ln -sf qvm-device.1.gz $(DESTDIR)/usr/share/man/man1/qvm-block.1.gz
-	ln -sf qvm-device.1.gz $(DESTDIR)/usr/share/man/man1/qvm-pci.1.gz
-	ln -sf qvm-device.1.gz $(DESTDIR)/usr/share/man/man1/qvm-usb.1.gz
+	# skipping qvm-device symlink installation, qvm-device is a binary in qubes-core-admin-client, not in qubes-core-admin!
 	$(MAKE) install -C relaxng
 	mkdir -p $(DESTDIR)/etc/qubes
 ifeq ($(BACKEND_VMM),xen)
-- 
2.45.2

The value to a user, and who that user might be

https://github.com/NixOS/nixpkgs/blob/19915ebb28f3f79ddd3b18b7bf22af1ac9c4fc88/pkgs/development/python-modules/qubes-core-admin/0002-fix-broken-qvm-device-symlinks.patch

Completion criteria checklist

(This section is for developer use only. Please do not modify it.)

[ethnh]

https://github.com/QubesOS/qubes-core-admin/blob/7b755c7e93712c66fcfc7e1df19d49b9c3bba6d9/Makefile#L182

[marmarek]

QubesOS/qubes-core-admin#573
QubesOS/qubes-core-admin-client#269