Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4.2: restoring backups crashes #8047

Closed
marmarek opened this issue Feb 15, 2023 · 6 comments · Fixed by QubesOS/qubes-core-admin-client#232
Closed

R4.2: restoring backups crashes #8047

marmarek opened this issue Feb 15, 2023 · 6 comments · Fixed by QubesOS/qubes-core-admin-client#232
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.2-host-cur-test r4.2-vm-bookworm-cur-test r4.2-vm-bullseye-cur-test r4.2-vm-centos-stream8-cur-test r4.2-vm-fc36-cur-test r4.2-vm-fc37-cur-test
Milestone

Comments

@marmarek
Copy link
Member

Observation

openQA test in scenario qubesos-4.2-pull-requests-x86_64-system_tests_backup@64bit fails in
TC_00_Backup

Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/qubes/tests/integ/backup.py", line 223, in restore_backup
    restore_op = self.loop.run_until_complete(
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/asyncio/base_events.py", line 653, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/qubesadmin/backup/restore.py", line 967, in __init__
    self.backup_app = self._process_qubes_xml()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^
qubesadmin.exc.QubesException: unable to extract the qubes backup. Check extracting process errors.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib64/python3.11/contextlib.py", line 81, in inner
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/qubes/tests/integ/backup.py", line 369, in test_000_basic_backup
    self.restore_backup()
  File "/usr/lib/python3.11/site-packages/qubes/tests/integ/backup.py", line 222, in restore_backup
    with self.assertNotRaises(qubesadmin.exc.QubesException):
  File "/usr/lib/python3.11/site-packages/qubes/tests/__init__.py", line 281, in __exit__
    raise self.failureException(
AssertionError: QubesException('unable to extract the qubes backup. Check extracting process errors.') raised, traceback:
  File "/usr/lib/python3.11/site-packages/qubes/tests/integ/backup.py", line 223, in restore_backup
    restore_op = self.loop.run_until_complete(
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/asyncio/base_events.py", line 653, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/qubesadmin/backup/restore.py", line 967, in __init__
    self.backup_app = self._process_qubes_xml()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/qubesadmin/backup/restore.py", line 1378, in _process_qubes_xml
    raise QubesException(

Test suite description

  1. Make a backup
  2. Restore it

See test code at https://github.com/QubesOS/qubes-core-admin/blob/main/qubes/tests/integ/backup.py#L360

Reproducible

Fails since (at least) Build 2023021319-4.2

Expected result

Last good: 2023011805-4.2 (or more recent)

Further details

Always latest result in this scenario: latest

@marmarek
Copy link
Member Author

This looks to be a python bug, this one specifically: python/cpython#88110

@andrewdavidwong andrewdavidwong added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. labels Feb 16, 2023
@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-admin-client has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bullseye-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-admin-client has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bookworm-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-admin-client (including package core-admin-client) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-admin-client (including package core-admin-client) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-admin-client has been pushed to the r4.2 testing repository for the CentOS centos-stream8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.2-host-cur-test r4.2-vm-bookworm-cur-test r4.2-vm-bullseye-cur-test r4.2-vm-centos-stream8-cur-test r4.2-vm-fc36-cur-test r4.2-vm-fc37-cur-test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants