Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Whonix Tray Icon #5813

Closed
ninavizz opened this issue May 11, 2020 · 11 comments
Closed

Update Whonix Tray Icon #5813

ninavizz opened this issue May 11, 2020 · 11 comments
Assignees
Labels
C: manager/widget C: Whonix This issue impacts Qubes-Whonix P: default Priority: default. Default priority for new issues, to be replaced given sufficient information.

Comments

@ninavizz
Copy link
Member

ninavizz commented May 11, 2020

Tracking as child w/in #5807


The problem you're addressing (if any)
The sdw-date iconography that surfaces in the Qubes tray, is not intuitive to users unfamiliar with the technical details of Whonix.

A majority of Qubes users will simply want to know if Whonix is or is not connected securely: yes or no. The clock semiotic only speaks to users who understand the concept of time-sync. This imposes a cognitive burden on all non-technical Qubes users, and users new to both Qubes and operating a computer in a high opsec environment.

The existing clock icons are also difficult to decipher at the small sizes they currently display.

Describe the solution you'd like
In the directory here, the two existing Qubes tray icons for Whonix exist at 32x32

I am proposing these two, that will clearly signal "Yes" or "No" with regards to the "Is Whonix (securely) connected?" question this widget's functionality exists to answer. Shown below is my own Qubes tray, mocked-up with the "Yes" icon; and, yes, I have 2 Whonix VMs.

image

TS_Success-32

TS_Stopped-32

^^ Note: The icons in the existing directory, are something like 27x32, not 32x32. I know in a priour version, the icon appeared in my Qubes tray "broken," with a horizontal repeat. @marmarta fixed that, and I don't know if that fix was simply making the not-square icons square, or in code. FYI, the icons provided above, should be properly square PNG files, despite the lock-shapes not being properly square.

Where is the value to a user, and who might that user be?

  • New users to Qubes, unfamiliar with how time-sync works
  • Users who understand time-sync but don't want to squint at the existing icons to decipher them

Describe alternatives you've considered
Replacing the existing icons with these, feels like the lowest-burden solution possible, with a high return via a semiotic that clearly speaks to the Whonix branding, and in a clearly discernible symbol for the size of the space.

Additional context
CC'ing @troubadoour and in Phabricator for visibility.

I suspect the majority of the "work" with implementing this, will be in change-management wrt updating screenshots on both the Whonix and Qubes websites, and possibly documentation texts. I'm not a developer, so don't know how to do either the above, or changing out the icon in the production repo.

@ninavizz ninavizz added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement labels May 11, 2020
@marmarta marmarta self-assigned this May 12, 2020
@marmarta
Copy link
Member

marmarta commented May 12, 2020

@ninavizz a question: I see there three possible states: 'success' 'wait' and 'stopped'. Obviously we'd like to replace the 'success' and 'stopped' - are you proposing to also replace 'wait' with the same icon as 'stopped'?

@ninavizz
Copy link
Member Author

@marmarta Aah, thank you! I'd only seen 2 of the 3 you mentioned. Update pending...

@ninavizz
Copy link
Member Author

@marmarta Follow-up question (because my Qubes machine is in the middle of a very lengthy update and I can't look for myself): Will the "Stopped" and "Waiting" icons be colored to the VM as the "Success" icon is?

@ninavizz
Copy link
Member Author

ninavizz commented May 12, 2020

I created this 'lil group... and would like to do an animated spinner as part of the "waiting" one, if that's possible to do. The clock semiotic just isn't working for me. I'd also personally prefer to not see these colored per the VM, but I'm curious what you and other users might think of that.

I question how many users understand what Time Sync is, or get the clock semiotics. Shifting the functional direction of the sdw-timesync widget to be a more general Whonix widget feels like a broader beneficial direction to move towards.

Thoughts?

WhonixLox

@marmarta
Copy link
Member

As far as shifting it to a more general 'Whonix' semiotics, I'm not sure - I don't consider myself enough of a Whonix pro to feel comfortable with answering this. I'm tempted to say this is not a great idea, because clock sync is just part of bigger Whonix ecosystem and what if it fails but the rest does not?

As far as animated icons go, the short answer is that as far as I can tell, doing it as an animated icon is doable although more complex, and probably I will be the person to do it, so I'm much more in favor of a non-animated one :D

@ninavizz
Copy link
Member Author

ninavizz commented May 12, 2020

Your points are all fair, and point to a broader question: who should UI elements be optimized for, and do those optimizations leave other users behind? Ideally things could follow a pattern of "Broadest Possible Functionality" at the top level, then narrow down depending on how deeply the user navigates. I like the Time Sync stuff being at a top level w/in the Whonix menu itself, but at the basic "access Whonix things" level of the Tray, non-power users still need to access Whonix functionality to reboot Tor, see its status, etc.

It's currently not intuitive that a clock icon is what one clicks on to access any/all Whonix controls... and it's proving difficult for folks to remember.

To your broader point, tho, I'd love to get some ideas in front of Whonix users—both in Qubes and in other environments—to get feedback. And, ok, without an animated icon for "Waiting." :)

@marmarek
Copy link
Member

Can we please move the discussion about Whonix part to Whonix issue tracker? I don't think ppl most competent to answer (Whonix developers) are monitoring every issue here...
There is already issue for this: https://phabricator.whonix.org/T991

ninavizz referenced this issue in Kicksecure/sdwdate-gui May 13, 2020
@adrelanos
Copy link
Member

I am happy to subscribe here. As long as github notifications are functional, I'll usually follow. Please tag @adrelanos to notify me.
Can't follow all Qubes tickets (did that in past) but it's too much to keep following all.
I am using https://phabricator.whonix.org as a reminder / roadmap.

One thing worth mentioning:
In future networking will be blocked [1] until sdwdate succeeded. sdwdate-gui status "in progress" ("wait") will reflect that. Ticket: https://phabricator.whonix.org/T533

[1] Technical detail: All traffic blocked except obviously Tor and sdwdate.

The existing clock icons are also difficult to decipher at the small sizes they currently display.

Agreed. The port to Qubes didn't implement graphics well.

I see there three possible states: 'success' 'wait' and 'stopped'.

Indeed.

Will the "Stopped" and "Waiting" icons be colored to the VM as the "Success" icon is?

Qubes (not Whonix) will always re-color.

and would like to do an animated spinner as part of the "waiting" one, if that's possible to do.

I don't know if that is possible without code changes. Only way to find out is a test. If you have a test gif image it can be tried out.
That would be nicer indeed.

I'd also personally prefer to not see these colored per the VM, but I'm curious what you and other users might think of that.

Guess this needs to be discussed separately in own ticket / conversation with Qubes.

I question how many users understand what Time Sync is, or get the clock semiotics.

Right...

As far as animated icons go, the short answer is that as far as I can tell, doing it as an animated icon is doable although more complex, and probably I will be the person to do it, so I'm much more in favor of a non-animated one :D

I had no idea if Qubes doesn't support animated systray icons but I guess that is what was just said.

To your broader point, tho, I'd love to get some ideas in front of Whonix users

Could write a guest post at Whonix news and/or Qubes blog?

Shifting the functional direction of the sdw-timesync widget to be a more general Whonix widget feels like a broader beneficial direction to move towards.

That is already somewhat the case since sdwdate-gui also shows Tor status, allows to start Tor control panel. So, yes, can be the Whonix widget. Also positive feedback by me as per https://phabricator.whonix.org/T963

My goal was to address all points. Please remind me should something be left unanswered.

@andrewdavidwong andrewdavidwong added C: manager/widget C: Whonix This issue impacts Qubes-Whonix labels May 14, 2020
@andrewdavidwong andrewdavidwong added this to the Far in the future milestone May 14, 2020
@brendanhoar
Copy link

@marmarta Follow-up question (because my Qubes machine is in the middle of a very lengthy update and I can't look for myself): Will the "Stopped" and "Waiting" icons be colored to the VM as the "Success" icon is?

Just wanted to note that the whonix (nee sdwdate) applet will always be running within the context of a particular instance of a sys-whonix{,-xyz,-etc} based on the whonix-gw template. Most users have either zero or one of these. Typically if one, it is called sys-whonix. Some users have several for multiple TOR entry points (waves hands re: security best practices) so the user can color them appropriate to the context.

FWIW, I've moved to using grey for all default sys-* VMs, so my default sdwdate icon color is grey.

@ninavizz
Copy link
Member Author

@brendanhoar Thank you for clarifying that! I run a Qubes machine provisioned by an org, specifically for our customers—and indeed, we have 2 Whonix instances, on it. Good to hear feedback from your own observations.

@adrelanos Many, many thanks to your detailed feedback, above! As noted in the Whonix Phabricator, I am working on getting funding secured for Whonix UX work. Parallel to that, I'd also like to get funding secured to pay a GUI developer to implement the improvements.

I will email you directly, about getting a blog post up—as I feel that would be a terrific way to engage folks, both to contribute to structured user feedback, and to express interest in consideration for paid developer work. Likewise, about the funding applicaiton itself.

Per @marmarek's note, above, I'm closing this issue, here. Also, because @adrelanos pushed the icons to the Whonix repo, yesterday—so the concern this issue was created to address, has already been tended to.

I am still interested in learning when the updated icon will ship, so that I can inform our training team so that they're not surprised.

@ninavizz
Copy link
Member Author

Oops, hit the wrong button... :D

@andrewdavidwong andrewdavidwong removed this from the Release TBD milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: manager/widget C: Whonix This issue impacts Qubes-Whonix P: default Priority: default. Default priority for new issues, to be replaced given sufficient information.
Projects
None yet
Development

No branches or pull requests

6 participants