Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from python-u2flib-host to python-fido2 #5501

Closed
SaswatPadhi opened this issue Dec 5, 2019 · 5 comments · Fixed by QubesOS/qubes-app-u2f#31
Closed

Switch from python-u2flib-host to python-fido2 #5501

SaswatPadhi opened this issue Dec 5, 2019 · 5 comments · Fixed by QubesOS/qubes-app-u2f#31
Labels
C: CTAP/U2F proxy Client to Authenticator Protocol (CTAP) / Universal 2nd Factor (U2F) proxy P: major Priority: major. Between "default" and "critical" in severity. pr submitted A pull request has been submitted for this issue.
Milestone

Comments

@SaswatPadhi
Copy link

SaswatPadhi commented Dec 5, 2019

The problem you're addressing (if any)
The python-u2flib-host project page says that it has been superseded by python-fido2.

Where is the value to a user, and who might that user be?
Issue #5400 reports that Google Titan U2F keys were not recognized by Qubes. I have had similar experience with OnlyKey. The solution in both cases was a patch that adds a new device to the python-u2flib-host library, but qubes-python-u2flib-host still seems to be using the 3.0.3 release (from > 1.5 years ago).

Since python-fido2 is still in beta stage, as the authors warn on the project page, may be qubes-python-u2flib-host could use the latest python-u2flib-host sources for the time being and switch to python-fido2 once it's stable?

@SaswatPadhi SaswatPadhi added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement labels Dec 5, 2019
@andrewdavidwong andrewdavidwong added this to the Far in the future milestone Dec 6, 2019
@marmarek marmarek added P: major Priority: major. Between "default" and "critical" in severity. and removed P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Nov 25, 2020
@DemiMarie DemiMarie self-assigned this Apr 9, 2022
@SaswatPadhi
Copy link
Author

python-fido2 is stable now. The 1.0.0 version was released recently:

https://github.com/Yubico/python-fido2/releases/tag/1.0.0

@DemiMarie DemiMarie modified the milestones: Release TBD, Release 4.2 Jul 17, 2022
@DemiMarie
Copy link

Now that python-fido2 is stable, it is definitely time to implement this.

@marmarek marmarek assigned piotrbartman and unassigned DemiMarie Dec 12, 2022
@marmarek marmarek modified the milestones: Release 4.2, Release TBD Dec 12, 2022
@ctr49
Copy link

ctr49 commented May 6, 2023

as far as I can tell it is just a drop-in replacement. changing
import u2flib_host.u2f to import fido2
worked out of the box for me (using qu2f-proxy)

@piotrbartman
Copy link
Member

as far as I can tell it is just a drop-in replacement. changing import u2flib_host.u2f to import fido2 worked out of the box for me (using qu2f-proxy)

@ctr49 First, thank you for your contribution! but we want full support here for fido2 devices (such as ClientPIN).

@ctr49
Copy link

ctr49 commented May 8, 2023

Fair point - nevertheless u2flib_host.u2f is deprecated and using fido2 instead of it doesn't break anything while allowing platforms to use it that don't have access to the deprecated library (in my case: Gentoo - see fepitre/qubes-gentoo#15). So you may want to consider creating a small maintenance release (1.2.11?) with python-fido2 and t-pa's #29 and then go for full scale fido2 support in a 1.3 version.

@andrewdavidwong andrewdavidwong added the pr submitted A pull request has been submitted for this issue. label May 22, 2023
@andrewdavidwong andrewdavidwong modified the milestones: Release TBD, Release 4.2 May 22, 2023
@andrewdavidwong andrewdavidwong added C: CTAP/U2F proxy Client to Authenticator Protocol (CTAP) / Universal 2nd Factor (U2F) proxy and removed C: other labels Sep 19, 2023
@piotrbartman piotrbartman removed their assignment Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: CTAP/U2F proxy Client to Authenticator Protocol (CTAP) / Universal 2nd Factor (U2F) proxy P: major Priority: major. Between "default" and "critical" in severity. pr submitted A pull request has been submitted for this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants