-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX issues with qrexec service confirmation dialogs - missing target default value #3251
Comments
I believe this is intentional, as explained here: @marmarek, what do you think? |
Yes, this is intentional. If for some particular service it is desired to have some default value there, the qrexec policy needs to be adjusted for that, adding
As for So, I think documentation for some services needs to be adjusted (qubes.VMAuth, split gpg etc), to include |
Thanks, that solves a lot of my issues. The qrexec documentation also needs to be adjusted, there is no mention of |
I think the solution could be to have qvm-copy-to-vm and qvm-move-to-vm print a warning that they are deprecated and that qvm-copy and qvm-move should be used instead. For instance, I just learned that by reading this bug. |
And ideally some help text in the confirmation dialog that says "if you want to specify a target in the VM issuing the request, add a specific allow rule in the Qubes RPC policy for that specific source and target VM combination before the ask rule" (perhaps only shown after clicking on a "I want to specify a target from the VM" hyperlink to avoid polluting the dialog too much). |
That would encourage such configuration, which not what we want to achieve. In fact this change is especially to take out control over target domain from the source domain, where possible/sensible. But including such cases in documentation (where we have more space, also for recommendations) is a good idea. |
Added |
Automated announcement from builder-github The package
|
Automated announcement from builder-github The package
|
Automated announcement from builder-github The package
|
Automated announcement from builder-github The package
|
Automated announcement from builder-github The package
|
Automated announcement from builder-github The package
|
Automated announcement from builder-github The package
|
Automated announcement from builder-github The component
|
Reopening for three reasons:
|
2. `qvm-copy` appears to have an incorrect usage message, as reported in #4207 (comment):
```
$ qvm-copy
usage: /usr/bin/qvm-copy-to-vm [--without-progress] dest_vmname file [file]+
$ qvm-copy-to-vm
usage: /usr/bin/qvm-copy-to-vm [--without-progress] dest_vmname file [file]+
```
This is a duplicate of
#3529 (already fixed in
master).
|
This doc is outdated because the confirmation(for
thus the |
Indeed, it is slightly different on R4.0. For this to work, you need to add following line to
(replace SOURCE_APPVM with actual VM name, or Alternatively, you can use
The latter generally should be preferable, as the source VM doesn't learn about other VM names, but will not work if you want multiple .desktop file for opening links in different VMs. |
Qubes OS version:
R4.0 RC2
Affected TemplateVMs:
all (dom0 issue)
Steps to reproduce the behavior:
Try to execute a simple Qubes RPC call, for example try to copy a file from one VM to another with
qvm-copy-to-vm
, plug in an external keyboard/mouse, use VMAuth (yeah, I know...:) ), sign a git commit with split gpg, etc. - most RPC actions with anask
policy.Expected behavior:
A simple dialog opens and with minimum friction the user chooses whether to allow the requested action or not.
Actual behavior:
The "Operation execution" dialog is missing a default
target
value and it always has to be chosen from the dropdown. This leads to significantly more friction (instead of "escape or enter" / "yes or no" quick choice by the user), first the dropdown value has to be populated.General notes:
That behavior is ok for calls like
qvm-copy
that do not specify the destination VM initially, but it's annoying for:VMAuth
andInputMouse
/InputKeyboard
have only one possible target in the dropdown and it should be pre-populated or missing altogether.qvm-move-to-vm
,qvm-copy-to-vm
for which I have to write the destination VM twice - once in the command itself and once in the dom0 dialogsplit-gpg
- what's the point of specifying/rw/config/gpg-split-domain
if I have to enter it again every time anywayRelated issues:
None that I could find
The text was updated successfully, but these errors were encountered: