Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip VMs without states defined in salt top file _only_ when executing operation using that top file #2451

Closed
marmarek opened this issue Nov 22, 2016 · 7 comments
Labels
C: mgmt P: minor Priority: minor. The lowest priority, below "default." r4.0-buster-stable r4.0-centos7-stable r4.0-dom0-stable r4.0-fc27-stable r4.0-fc28-stable r4.0-fc29-stable r4.0-jessie-stable r4.0-stretch-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@marmarek
Copy link
Member

Currently qubesctl tool skip VMs for which top file is empty (it checks state.show_top id=VMNAME). It is sensible for state.highstate which would do nothing, but break usage of other commands, like giving state to apply from command line (state.single, state.apply, state.sls...), or even directly calling some salt module.

@marmarek marmarek added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: mgmt P: minor Priority: minor. The lowest priority, below "default." labels Nov 22, 2016
@marmarek marmarek added this to the Release 3.2 updates milestone Nov 22, 2016
@maertsen
Copy link

I have tested QubesOS/qubes-mgmt-salt@5fc8aee and can confirm this solves #2718 for me, including using that same method via QubesOS/qubes-desktop-linux-manager#34.

Thanks for fixing this, this really simplifies my update workflow.

@qubesos-bot
Copy link

Automated announcement from builder-github

The package mgmt-salt has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-mgmt-salt-4.0.14-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-mgmt-salt_4.0.14-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-mgmt-salt_4.0.14-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package mgmt-salt has been pushed to the r4.0 stable repository for the CentOS centos7 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-mgmt-salt-4.0.14-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: mgmt P: minor Priority: minor. The lowest priority, below "default." r4.0-buster-stable r4.0-centos7-stable r4.0-dom0-stable r4.0-fc27-stable r4.0-fc28-stable r4.0-fc29-stable r4.0-jessie-stable r4.0-stretch-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

No branches or pull requests

3 participants