-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide colorblind options for State column in Qube Manager #1533
Comments
@bnvk any ideas? Maybe different shapes? Best Regards, |
I think replacing the green dot with an "On" icon and replacing the yellow dot with something else should work. While not colorblind, I've never been sure what the yellow dot actually means @marmarek ? |
@andrewdavidwong Confirmed this issue still arises in 3.2 milestone, although it should be trivial to resolve. |
I'm afraid we don't have one at the moment. |
This issue is being closed because:
If anyone believes that this issue should be reopened, please let us know in a comment here. |
this is still a problem with the Qube Manager so I will re-open, have changed Milestone to Far in the Future and added "help wanted" and "accessibility" tags. |
Specifically for Qube Manager, I would advocate for using differently colored and shaped symbols instead of colored circles. So, proper Icons. Google's (I know, I know) Material icon library is completely free and open-source, and is my go-to resource for icons to use in dense software contexts. Semiotics (metaphors) and decipherable rendering at size are of equal importance for usability and accessibility. Gnome's icons, I don't consider to be fit for use at 18x18 and below, as they're far too complex with gradients and outlines and other details. They do have smaller icons, but "pictograms" is a better description of icons to meet this sort of need. Something dead-simple, and not very illustrative. Font Awesome is a popular community resource in FOSS, however I'm less a fan of it because its icons are a touch more "fussy" and thus a tad more difficult to cognitively parse, than those in the Material library. As evil as the Big G is, they do pay a large staff quite well to do nothing but sketch, design, test, and iterate on icons. Icon design is very hard to do well, and G's commitment to create and execute them well, shows. When I need to create custom icons, I'll use thenounproject.com as a source-material resource, and also as a generally brainstorming resource. Coming back to Qube Manager status icons: It would help for me if someone could list all of the different "states" here. What exactly are they, and what do they mean? As I'm aware, there's currently a "green" and a "yellow" state. I can assume a lot from those colors, but would love to know, conclusively, what is really meant by those states. Also, if there are any others. Happy to take a quick pass, if I can just get some clarity around what is being communicated to the user, first. :) |
Icons we have signify the following states:
|
Yes, my only interest in an animated state, would be for when a VM is transient. Unless I am misunderstanding what "Transient" means? Agreed, an animated icon is only for when a thing is doing something that the animation stopping, will signify to a user "this is done!"
Fair enough. I disagree, but in this moment that is just the two of us speaking anecdotally in regards to our own preferences. Yes, if the funding existed, I would want to go to town on icons in user testing, lol. As a general rule, if an icon is not clear in its semiotics, it won't serve that useful purpose for users and is "visual clutter." The current toolbar icons are both unclear to me, and feel like tasks better suited to an actions menu. But, those are things for a bigger discussion at another time. :) |
Oh yeah, then definitely! and you have understood correctly - transient should never be permanent, it means that VM is starting or stopping or completely exploded somehow :D |
Okee doke @marmarek @marmarta a first stab at this! Within this direction, are also a few minor tidy-ups of Qube Manager. The goals, being 1. Facilitate improved legibility, and 2. To align semiotics used here, with the new app menu (so, bold/not-bold = running/not-running, same use of icons).
States
|
Currently the table in our Qube Manager has alternating white/light gray rows. Which is useful to follow which info on the right is about which qube on the left. Is this intentionally gone in this design? Without that, it requires some effort to, for example, find what is IP of qube 'untrusted' on the picture above. |
@marmarek I do not have those alternating white/gray lines on my own So: personally, I dislike them, because they feel busy and heavy-handed—but to your functional issue cited above, they do serve a purpose. I updated my wireframe to show pale gray lines that do not go the full width of the table—such that the icons on the left are not made too busy. Also of note, the pale blue icon for launching a VM, is supposed to be an animation. What do you think about this? I'd also forgotten to bold a couple items to be consistent with their rows, fwiw, in the PNG above. |
You guys had them, took them out, then put them back in again?
This might depend on the theme you choose in XFCE?
Which reminds me: how will your new design interact with themes? ...
will there be a dark mode?
Dark mode is very important: I sit 10+ hours a day in front of the
screen. My eyes just can't take all the white. Light themes look a lot
prettier but after a while my eyes and head start to hurt. Even with
Redshift etc.
|
@SvenSemmler I have been running the Atlanta theme in XFCE, and changed it to the default—and, no lines. Regardless... it feels weird that desktop themes would impact core UI components, such as how tables are rendered. Thank you for the flag on Dark Theme, tho! Generally I don't like this whole (gestures arms in the air wildly while making faces and rolling eyes) theming hootenanny that Linux people love. So, will potentially be a bit of a grouch about it. That said, the Light/Dark theme paradigm I do agree is important, for basic usability things—and I want to support for this! Which version of Qubes are you running, Sven? I do not believe If you're comfortable sharing screenshots here on GH, it would help me a lot if you could maybe send me a couple screenies showing your custom Qubes widgets, and Qube Manager, all in Dark Theme—such that I can work with those as a baseline for how things currently look? Same, with File Manager, just so I have that as a reference? Assuming you use some kind of a very general/basic kind of a "Dark" theme? You also have my email, and if you're not comfortable sharing them here I'd love to see them via email, if you'd be comfortable with that. nina at research.qubes-os.org, or my gmail are good. Once I have a sense of how Dark Theme works in QM for ...and, yes, I am getting a machine to run |
I find white/gray pattern a bit easier to follow in a wide table, but IMO this is good enough too. |
Ohh, but you are @marmarek and I want you of all ppl to be happy with this stuff! So, the biggest difference between the current table'd layout, and what I'm proposing in #5679, is that the "rows" in the newer design are not literal table rows with 1:1 columns to data-type/column. As such, that iteration on QM has a far narrower total-width of the view, which makes it easier to visually scan and to find things. I have much of the information hidden in my own QM (as you can tell from the mockups), to keep that burden low, for myself, but I could see how for power-users that could be problematic. TL;DR, I'm fine exploring how to do the alternating line background colors, as it would clearly make you happier. :) Will do for both light and dark, in a next iteration. |
I love it! |
@marmarek Hooray! My only bias against it the gray background across the whole table, is that it reminds me of old DOS-era interfaces, lol. :) Will post artwork for icons, here, at some point. Who will be building this—@marmarta? If it is not Marta, I'll need to invite whomever else it is, to my spec tool, Zeplin, so that they can get all the hex and pixel values, and the gradient from the headers. Would also love to know how to best get the spinner handed-off... altho for SecureDrop's client (also done in QT) I just delivered an animated GIF. If that's ok, will do the same, here! |
It's also helpful if hovering the mouse cursor highlights that whole row. |
A unique hover color for the row the mouse is hovering over, I definitely want @andrewdavidwong! One thing I have learned while working with the SecureDrop team building their SD client in QT, is that QT is a pain to work with for UI styling. So, I wanted to keep the scope on this initial push, lean. I don't know how the existing QM does things (and my qubes laptop is packed as I just returned from travels), but if that is not currently in QM I definitely want to see it added, at some point! |
Is GTK easier to work with from a styling perspective? Also, does SecureDrop have any ideas on GTK vs Qt and/or GNOME vs KDE? |
@DemiMarie I would love to discuss and compare the detailed differences between Anabaptist communities, on GitHub (my favorite of all Issue segues), but promised Andrew I'd be better about staying on topic, myself—while also encouraging others to do the same. Yes, the entire SecureDrop team has many opinions on many things. Too many, in fact, for their own sanity, some of the time. I'll work on coordinating a knowledge-share between teams, sometime. But let's keep the GTK vs QT and GNOME vs KDE chatter to the forums or Wire, for the while. Especially since this issue is soooooo close to being closed. <3 |
The yellow and green of the State column in Qubes VM Manager are hard to distinguish for colorblind users.
thanks for reporting @hdevalence
The text was updated successfully, but these errors were encountered: