Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide colorblind options for State column in Qube Manager #1533

Open
mfc opened this issue Dec 21, 2015 · 33 comments
Open

Provide colorblind options for State column in Qube Manager #1533

mfc opened this issue Dec 21, 2015 · 33 comments
Labels
accessibility This issue concerns the use of Qubes OS by persons with disabilities. C: manager/widget P: minor Priority: minor. The lowest priority, below "default." T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. ux User experience

Comments

@mfc
Copy link
Member

mfc commented Dec 21, 2015

The yellow and green of the State column in Qubes VM Manager are hard to distinguish for colorblind users.

thanks for reporting @hdevalence

@mfc mfc added the ux User experience label Dec 21, 2015
@marmarek
Copy link
Member

@bnvk any ideas? Maybe different shapes?

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

@marmarek marmarek added this to the Release 3.1 milestone Dec 21, 2015
@marmarek marmarek added T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. C: manager/widget P: minor Priority: minor. The lowest priority, below "default." labels Dec 21, 2015
@bnvk
Copy link

bnvk commented Feb 18, 2016

I think replacing the green dot with an "On" icon and replacing the yellow dot with something else should work. While not colorblind, I've never been sure what the yellow dot actually means @marmarek ?

@unman
Copy link
Member

unman commented Apr 16, 2017

@andrewdavidwong Confirmed this issue still arises in 3.2 milestone, although it should be trivial to resolve.
Who is our go to UX person?

@andrewdavidwong
Copy link
Member

Who is our go to UX person?

I'm afraid we don't have one at the moment.

@andrewdavidwong
Copy link
Member

This issue is being closed because:

If anyone believes that this issue should be reopened, please let us know in a comment here.

@mfc mfc modified the milestones: Release 3.2 updates, Far in the future Apr 1, 2019
@mfc mfc added help wanted This issue will probably not get done in a timely fashion without help from community contributors. accessibility This issue concerns the use of Qubes OS by persons with disabilities. labels Apr 1, 2019
@mfc
Copy link
Member Author

mfc commented Apr 1, 2019

this is still a problem with the Qube Manager so I will re-open, have changed Milestone to Far in the Future and added "help wanted" and "accessibility" tags.

@mfc mfc reopened this Apr 1, 2019
@mfc mfc modified the milestones: Far in the future, Release 4.0 updates Apr 2, 2019
@ninavizz
Copy link
Member

ninavizz commented Apr 7, 2021

Specifically for Qube Manager, I would advocate for using differently colored and shaped symbols instead of colored circles. So, proper Icons.

Google's (I know, I know) Material icon library is completely free and open-source, and is my go-to resource for icons to use in dense software contexts. Semiotics (metaphors) and decipherable rendering at size are of equal importance for usability and accessibility.

Gnome's icons, I don't consider to be fit for use at 18x18 and below, as they're far too complex with gradients and outlines and other details. They do have smaller icons, but "pictograms" is a better description of icons to meet this sort of need. Something dead-simple, and not very illustrative. Font Awesome is a popular community resource in FOSS, however I'm less a fan of it because its icons are a touch more "fussy" and thus a tad more difficult to cognitively parse, than those in the Material library. As evil as the Big G is, they do pay a large staff quite well to do nothing but sketch, design, test, and iterate on icons. Icon design is very hard to do well, and G's commitment to create and execute them well, shows. When I need to create custom icons, I'll use thenounproject.com as a source-material resource, and also as a generally brainstorming resource.

Coming back to Qube Manager status icons: It would help for me if someone could list all of the different "states" here. What exactly are they, and what do they mean? As I'm aware, there's currently a "green" and a "yellow" state. I can assume a lot from those colors, but would love to know, conclusively, what is really meant by those states. Also, if there are any others.

Happy to take a quick pass, if I can just get some clarity around what is being communicated to the user, first. :)

@ninavizz
Copy link
Member

ninavizz commented Apr 9, 2021

^ @marmarta

@marmarta
Copy link
Member

marmarta commented Apr 9, 2021

Icons we have signify the following states:

  • VM is running (green circle)
  • VM is transient, so, either starting or stopping or weird (yellow circle)
  • updates available (down pointing green arrow)
  • template was changed, so VM needs restarting to reflect changes in template (gray arrows)

@ninavizz
Copy link
Member

On animations: Generally yes, although I'm a bit wary of introducing moving things to places where they are not needed. One thing is that I have this association that moving thing on a computer screen = something is in progress, and it will end and stop moving. Other thing is that animations introduce visual clutter, especially if someone likes to just keep the manager running on a side screen or something like that - it will make it look like something's happening when nothing is.

Yes, my only interest in an animated state, would be for when a VM is transient. Unless I am misunderstanding what "Transient" means? Agreed, an animated icon is only for when a thing is doing something that the animation stopping, will signify to a user "this is done!"

However, I really don't agree with removing menu icons. At least for me, they are quite helpful in seeing what a given option does at a glance (much faster to parse than words), and having the same icon on them as on the toolbar is helpful to remind me what things do.

Fair enough. I disagree, but in this moment that is just the two of us speaking anecdotally in regards to our own preferences. Yes, if the funding existed, I would want to go to town on icons in user testing, lol. As a general rule, if an icon is not clear in its semiotics, it won't serve that useful purpose for users and is "visual clutter." The current toolbar icons are both unclear to me, and feel like tasks better suited to an actions menu. But, those are things for a bigger discussion at another time. :)

@marmarta
Copy link
Member

marmarta commented Apr 12, 2021

On animations: Generally yes, although I'm a bit wary of introducing moving things to places where they are not needed. One thing is that I have this association that moving thing on a computer screen = something is in progress, and it will end and stop moving. Other thing is that animations introduce visual clutter, especially if someone likes to just keep the manager running on a side screen or something like that - it will make it look like something's happening when nothing is.

Yes, my only interest in an animated state, would be for when a VM is transient. Unless I am misunderstanding what "Transient" means? Agreed, an animated icon is only for when a thing is doing something that the animation stopping, will signify to a user "this is done!"

Oh yeah, then definitely! and you have understood correctly - transient should never be permanent, it means that VM is starting or stopping or completely exploded somehow :D

@ninavizz
Copy link
Member

ninavizz commented Jun 24, 2021

Okee doke @marmarek @marmarta a first stab at this!

Within this direction, are also a few minor tidy-ups of Qube Manager. The goals, being 1. Facilitate improved legibility, and 2. To align semiotics used here, with the new app menu (so, bold/not-bold = running/not-running, same use of icons).

  • All fonts now use Source Sans Pro family
  • Qubes that are not running are a dark gray
  • Qubes that are running are black
  • The far-left two column headers are visibly gone
  • The top sortable column header row is taller, and the gray divider lines have some white padding above and below them
  • The column header text is semi-bold
  • Column widths expand to support stupid-long qube names (such as those darn Buster templates the SD team uses)
  • A "sort" control was added to the row of buttons at the top, as an itterative step towards the most recent mockups in Redesign Qube Manager #5679
    • Categories in this sort dropdown would be: Status, Color, Type, Ascending, Descending
    • "Type" would include roles (so App, Template, Disp-Template, Service, Standalone, Admin, Manager)
    • "Status" would prioritize in order: Launching, Running, Paused, Frozen/Borked, Needing Reboots, Needing Updates

States

QM_Iterative-01b

@marmarek
Copy link
Member

Currently the table in our Qube Manager has alternating white/light gray rows. Which is useful to follow which info on the right is about which qube on the left. Is this intentionally gone in this design? Without that, it requires some effort to, for example, find what is IP of qube 'untrusted' on the picture above.

@ninavizz
Copy link
Member

@marmarek I do not have those alternating white/gray lines on my own 4.0 Qube Manager—but I used to. You guys had them, took them out, then put them back in again? Oyy!

So: personally, I dislike them, because they feel busy and heavy-handed—but to your functional issue cited above, they do serve a purpose. I updated my wireframe to show pale gray lines that do not go the full width of the table—such that the icons on the left are not made too busy.

Also of note, the pale blue icon for launching a VM, is supposed to be an animation.

What do you think about this? I'd also forgotten to bold a couple items to be consistent with their rows, fwiw, in the PNG above.

QM_Iterative-01c

@SvenSemmler
Copy link

SvenSemmler commented Jun 24, 2021 via email

@ninavizz
Copy link
Member

ninavizz commented Jun 24, 2021

@SvenSemmler I have been running the Atlanta theme in XFCE, and changed it to the default—and, no lines. Regardless... it feels weird that desktop themes would impact core UI components, such as how tables are rendered.

Thank you for the flag on Dark Theme, tho! Generally I don't like this whole (gestures arms in the air wildly while making faces and rolling eyes) theming hootenanny that Linux people love. So, will potentially be a bit of a grouch about it. That said, the Light/Dark theme paradigm I do agree is important, for basic usability things—and I want to support for this!

Which version of Qubes are you running, Sven? I do not believe 4.0 does Light/Dark theme support.

If you're comfortable sharing screenshots here on GH, it would help me a lot if you could maybe send me a couple screenies showing your custom Qubes widgets, and Qube Manager, all in Dark Theme—such that I can work with those as a baseline for how things currently look? Same, with File Manager, just so I have that as a reference? Assuming you use some kind of a very general/basic kind of a "Dark" theme? You also have my email, and if you're not comfortable sharing them here I'd love to see them via email, if you'd be comfortable with that. nina at research.qubes-os.org, or my gmail are good.

Once I have a sense of how Dark Theme works in QM for 4.1 I will hop to making a version of that, for this.

...and, yes, I am getting a machine to run 4.1 and test builds on, hopefully in a couple weeks.

@SvenSemmler
Copy link

@ninavizz since that's a different but related task/topic I took the freedom to start #6736

@marmarek
Copy link
Member

What do you think about this?

I find white/gray pattern a bit easier to follow in a wide table, but IMO this is good enough too.

@ninavizz
Copy link
Member

I find white/gray pattern a bit easier to follow in a wide table, but IMO this is good enough too.

Ohh, but you are @marmarek and I want you of all ppl to be happy with this stuff!

So, the biggest difference between the current table'd layout, and what I'm proposing in #5679, is that the "rows" in the newer design are not literal table rows with 1:1 columns to data-type/column. As such, that iteration on QM has a far narrower total-width of the view, which makes it easier to visually scan and to find things. I have much of the information hidden in my own QM (as you can tell from the mockups), to keep that burden low, for myself, but I could see how for power-users that could be problematic.

TL;DR, I'm fine exploring how to do the alternating line background colors, as it would clearly make you happier. :) Will do for both light and dark, in a next iteration.

@ninavizz
Copy link
Member

Updated. Needs adjustment for accessibility contrast!

QM_Iterative-01g

@marmarek
Copy link
Member

I love it!
The reason why I like this alternating white/gray pattern is that now I don't need to follow the whole row until the last column. I can look at the first column, see that "untrusted" is gray, and then look for gray at the last column around that height.

@ninavizz
Copy link
Member

@marmarek Hooray! My only bias against it the gray background across the whole table, is that it reminds me of old DOS-era interfaces, lol. :)

Will post artwork for icons, here, at some point. Who will be building this—@marmarta? If it is not Marta, I'll need to invite whomever else it is, to my spec tool, Zeplin, so that they can get all the hex and pixel values, and the gradient from the headers.

Would also love to know how to best get the spinner handed-off... altho for SecureDrop's client (also done in QT) I just delivered an animated GIF. If that's ok, will do the same, here!

@andrewdavidwong
Copy link
Member

It's also helpful if hovering the mouse cursor highlights that whole row.

@andrewdavidwong andrewdavidwong removed the help wanted This issue will probably not get done in a timely fashion without help from community contributors. label Jun 25, 2021
@andrewdavidwong andrewdavidwong changed the title [UX] provide colorblind options for State column in Qubes VM Manager Provide colorblind options for State column in Qube Manager Jun 25, 2021
@ninavizz
Copy link
Member

A unique hover color for the row the mouse is hovering over, I definitely want @andrewdavidwong! One thing I have learned while working with the SecureDrop team building their SD client in QT, is that QT is a pain to work with for UI styling. So, I wanted to keep the scope on this initial push, lean. I don't know how the existing QM does things (and my qubes laptop is packed as I just returned from travels), but if that is not currently in QM I definitely want to see it added, at some point!

@DemiMarie
Copy link

Is GTK easier to work with from a styling perspective? Also, does SecureDrop have any ideas on GTK vs Qt and/or GNOME vs KDE?

@ninavizz
Copy link
Member

@DemiMarie I would love to discuss and compare the detailed differences between Anabaptist communities, on GitHub (my favorite of all Issue segues), but promised Andrew I'd be better about staying on topic, myself—while also encouraging others to do the same.

Yes, the entire SecureDrop team has many opinions on many things. Too many, in fact, for their own sanity, some of the time.

I'll work on coordinating a knowledge-share between teams, sometime. But let's keep the GTK vs QT and GNOME vs KDE chatter to the forums or Wire, for the while. Especially since this issue is soooooo close to being closed. <3

@andrewdavidwong andrewdavidwong removed this from the Release 4.2 milestone Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility This issue concerns the use of Qubes OS by persons with disabilities. C: manager/widget P: minor Priority: minor. The lowest priority, below "default." T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. ux User experience
Projects
None yet
Development

No branches or pull requests

9 participants