qubesvm: don't crash VM creation if icon symlink already exists

It can be leftover from previous failed attempt. Don't crash on it, and replace it instead. QubesOS/qubes-issues#3438
QubesOS · Oct 17, 2018 · ba210c4 · ba210c4
1 parent c01ae06
commit ba210c4
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/qubes/vm/qubesvm.py b/qubes/vm/qubesvm.py
@@ -1439,6 +1439,8 @@ def create_on_disk(self, pool=None, pools=None):
                                    'creation'.format(self.dir_path))
             raise
 
+        if os.path.exists(self.icon_path):
+            os.unlink(self.icon_path)
         self.log.info('Creating icon symlink: {} -> {}'.format(
             self.icon_path, self.label.icon_path))
         if hasattr(os, "symlink"):