Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make classical and quantum channel delays customizable when initializ… #162

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

ba2tro
Copy link
Member

@ba2tro ba2tro commented Oct 10, 2024

No description provided.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.05%. Comparing base (b8721ad) to head (c72aed3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   68.05%   68.05%           
=======================================
  Files          41       41           
  Lines        1709     1709           
=======================================
  Hits         1163     1163           
  Misses        546      546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ba2tro ba2tro requested a review from Krastanov October 10, 2024 19:09
@ba2tro ba2tro added the Skip-Changelog label for control of CI: skips the changelog check label Oct 11, 2024
@Krastanov
Copy link
Member

Thanks! I will merge this shortly, after the tests pass. In general though, please have tests when new functionality is added -- this is definitely something that should have a test to make sure it is actually working.

@Krastanov Krastanov merged commit 3ccd676 into QuantumSavory:master Oct 24, 2024
15 of 16 checks passed
@Krastanov Krastanov mentioned this pull request Oct 24, 2024
@ba2tro ba2tro deleted the delay branch November 8, 2024 20:28
ba2tro added a commit to ba2tro/QuantumSavory.jl that referenced this pull request Nov 8, 2024
ba2tro added a commit to ba2tro/QuantumSavory.jl that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog label for control of CI: skips the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants