Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incompatibility with Julia 1.11.1 and remove the adjoint piracy #393

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

royess
Copy link
Contributor

@royess royess commented Oct 16, 2024

In this PR, the adjoint piracy is removed, which is related to #371 .

After this removal, an inner function group_algebra_conj is used in favor of reloading Base.adjoint. Some comments are also updated and corrected.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.01%. Comparing base (4e06c01) to head (ef02316).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ext/QuantumCliffordHeckeExt/lifted_product.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   83.03%   83.01%   -0.03%     
==========================================
  Files          70       70              
  Lines        4404     4410       +6     
==========================================
+ Hits         3657     3661       +4     
- Misses        747      749       +2     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@royess royess marked this pull request as ready for review October 16, 2024 10:09
@royess
Copy link
Contributor Author

royess commented Oct 16, 2024

@Krastanov please help review this PR. Thanks!

@Krastanov Krastanov added the Skip-Changelog label for control of CI: skips the changelog check label Oct 18, 2024
@royess
Copy link
Contributor Author

royess commented Oct 18, 2024

@Krastanov The new commit fixes the bug reported in #394, an incompatibility problem with Julia 1.11.1.

The fix may affect performance for large codes and require optimization in the future.

@royess royess marked this pull request as ready for review October 18, 2024 03:08
@royess royess changed the title remove the adjoint piracy fix incompatibility with Julia 1.11.1 and remove the adjoint piracy Oct 18, 2024
@Krastanov
Copy link
Member

Wonderful, thank you!

@Krastanov Krastanov merged commit be50f9c into QuantumSavory:master Oct 18, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog label for control of CI: skips the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants