Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

none of the decoders and evaluators should allocate #219

Open
5 tasks
Krastanov opened this issue Jan 19, 2024 · 0 comments
Open
5 tasks

none of the decoders and evaluators should allocate #219

Krastanov opened this issue Jan 19, 2024 · 0 comments
Labels
ECC Having to do with the ECC submodule performance bug Something is unreasonably slow

Comments

@Krastanov
Copy link
Member

evaluate_decoder might evaluate a couple of times during setup, but there should be no new allocations happening when we enter the sampling&decodeing loop. This would require removing allocations from:

  • the various LDPCDecoder.jl decoders
  • the various PyQDecoders.jl decoders
  • probably using batched in-place decoder interfaces for all of them (see In-place and batch decode functions #217 )
  • removing allocations from evaluate_decoder itself
  • add tests that verify that future changes do not cause things to allocate again (potentially including tests inside of the LDPCDecoder and PyQDecoder libraries)
@Krastanov Krastanov added performance bug Something is unreasonably slow ECC Having to do with the ECC submodule labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ECC Having to do with the ECC submodule performance bug Something is unreasonably slow
Projects
None yet
Development

No branches or pull requests

1 participant