Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pauli frames on circuits that measure [0,0,...,0] with 0% likelihood. #167

Open
amicciche opened this issue Aug 17, 2023 · 1 comment
Open
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@amicciche
Copy link
Member

amicciche commented Aug 17, 2023

Pauli frames always operate with a measurement reference sample, and it seems the current implementation assumes this reference sample is [0,0,...,0].
For our case, mostly working with error correction, a zero syndrome is always a possibility and so this problem hasn't come up yet.

However, when the circuit being simulated on the Pauli frame measures all zeroes with 0% likelihood, the Pauli Frames gives the wrong answer.
image

I suggest we add an optional argument to the constructor that can designates a non all-zero reference.

@Krastanov
Copy link
Member

I think it makes most sense to consider this a documentation issue. Pauli frames simulations inherently only provide samples with respect to a reference and we should put a few warning blocks in the documentation that this is the case, together with examples of how to make a reference simulation.

To the question of how to make a reference simulation... Let's start by documenting how it can be done right now, by running mctrajectory! separately. Then we can decide whether it is worth it to make it "built in" for the Pauli frame object.

@Krastanov Krastanov added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants