Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added classHash to debug page #232

Merged
merged 15 commits into from
Aug 9, 2024
Merged

Conversation

Jemiiah
Copy link
Contributor

@Jemiiah Jemiiah commented Aug 3, 2024

Task name here

Fixes #213

Types of change

  • used Address component with size xs
  • added classHash to GenericContract type
  • modify getContractDataFromDeployments to save classHash

@Jemiiah
Copy link
Contributor Author

Jemiiah commented Aug 3, 2024

@0xquantum3labs, Please review.

@@ -212,6 +212,7 @@ const preDeployedContracts = {
],
},
],
classHash: universalEthAddress, //used to for demostration and to remove ts-error
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the class hash of ETH in devnet is : 0x046ded64ae2dead6448e247234bab192a9c483644395b66f2155f2614e5804b0

in sepolia : 0x07f3777c99f3700505ea966676aac4a0d692c2a9f5e667f4c606b51ca1dd3420

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jemiiah any updates on this ? you will have to write the class hash i provided here in this line. not overwrite the universalEthAddress with the values i provided above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @0xquantum3labs, I did I pushed a commit yesterday implementing these changes

@0xquantum3labs
Copy link
Collaborator

Hello @Jemiiah , any updates on the PR ?

@Jemiiah Jemiiah requested a review from 0xquantum3labs August 6, 2024 19:07
@Jemiiah
Copy link
Contributor Author

Jemiiah commented Aug 6, 2024

Yes @0xquantum3labs just implemented those changes

Copy link
Contributor

@jrcarlos2000 jrcarlos2000 Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on file name

@@ -680,6 +681,7 @@ const preDeployedContracts = {
],
},
],
classHash: 0x07f3777c99f3700505ea966676aac4a0d692c2a9f5e667f4c606b51ca1dd3420
Copy link
Contributor Author

@Jemiiah Jemiiah Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file ser

@Jemiiah Jemiiah requested a review from jrcarlos2000 August 9, 2024 09:59
format,
size = "xs",
}: ClasshashProps) => {
const [addressCopied, setAddressCopied] = useState(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classHashCopied

@jrcarlos2000
Copy link
Contributor

please check failing workflow too @Jemiiah

@Jemiiah
Copy link
Contributor Author

Jemiiah commented Aug 9, 2024

okayyy

@Jemiiah Jemiiah requested a review from jrcarlos2000 August 9, 2024 11:16
@Jemiiah
Copy link
Contributor Author

Jemiiah commented Aug 9, 2024

Screenshot (36)
the workflow failing at the moment is not from my end it's from a Cairo contract

@jrcarlos2000
Copy link
Contributor

jrcarlos2000 commented Aug 9, 2024

workflow is updated @Jemiiah , the nextjs package is not building

@Jemiiah
Copy link
Contributor Author

Jemiiah commented Aug 9, 2024

looking into it now

@@ -939,6 +940,7 @@ const preDeployedContracts = {
],
},
],
classHash: "0x07f3777c99f3700505ea966676aac4a0d692c2a9f5e667f4c606b51ca1dd3420", //should be replaced with Strk Sepolia classHash. how do i get that?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class hash here is

classHash: "0x04ad3c1dc8413453db314497945b6903e1c766495a1e60492d44da9c2a986e4b",

And Remove comments

@Jemiiah Jemiiah requested a review from Nadai2010 August 9, 2024 15:52
@Jemiiah
Copy link
Contributor Author

Jemiiah commented Aug 9, 2024

@0xquantum3labs please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add class hash on debug page
4 participants