Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FCstd color support #91

Merged
merged 6 commits into from
Jan 17, 2023
Merged

FCstd color support #91

merged 6 commits into from
Jan 17, 2023

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Jan 6, 2023 •
edited
Loading

This uses the module OfflineRenderingUtils from freecad in order for it to load the GuiDocument.xml file that contains information about color and visibility of 3D objects, that freecad does not usually load if there is no GUI for freecad running.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/colors

@trungleduc trungleduc mentioned this pull request Jan 10, 2023
Merged
@martinRenou
Copy link
Member Author

martinRenou commented Jan 10, 2023 •
edited
Loading

TODO still:

  • visible state does not seem correct at initialization (in shapeToMesh)
  • shapeToMesh is being called way too often than it should
  • allow for picking colors from the GUI?
  • what do we do with the visible state coming from the object (not from guidata)? NOTHING

@martinRenou martinRenou marked this pull request as ready for review January 11, 2023 14:39
@martinRenou
Copy link
Member Author

This is ready for review.

The two remaining points from the comment above:

  • first one is not related to this PR, it should be fixed separately
  • second one could be implemented in a separate PR.

trungleduc
trungleduc reviewed Jan 11, 2023
View reviewed changes
jupytercad/freecad/loader.py Outdated Show resolved Hide resolved
jupytercad/freecad/loader.py Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
@trungleduc trungleduc self-assigned this Jan 16, 2023
@trungleduc
Copy link
Member

Galata update snapshots

@trungleduc
Copy link
Member

Galata please update snapshots

@trungleduc
Copy link
Member

Thanks @martinRenou

@trungleduc trungleduc merged commit de524d8 into jupytercad:main Jan 17, 2023
@martinRenou martinRenou deleted the colors branch January 23, 2023 08:19
@martinRenou martinRenou mentioned this pull request Feb 8, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees

@trungleduc trungleduc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @trungleduc