Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2D Editor #76

Merged
merged 4 commits into from
Jan 23, 2023
Merged

2D Editor #76

merged 4 commits into from
Jan 23, 2023

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Dec 21, 2022 •
edited
Loading

TODO:

  • Add more geometry types
  • Support dark theme
cad2.mp4

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/jupytercad/2d

@trungleduc trungleduc self-assigned this Jan 10, 2023
@trungleduc trungleduc marked this pull request as ready for review January 10, 2023 15:10
@trungleduc
Copy link
Member Author

I need to add new symbols to jupytercad-opencascade, so the UI tests won't pass since it still using the current NPM package.
@martinRenou how do I publish a new version of jupytercad-opencascade?

@martinRenou
Copy link
Member

@martinRenou how do I publish a new version of jupytercad-opencascade?

yarn publish from that directory (it will prompt you for bumping the version)

@trungleduc
Copy link
Member Author

@martinRenou how do I publish a new version of jupytercad-opencascade?

yarn publish from that directory (it will prompt you for bumping the version)

I have the publishing right of this package on NPM?

@martinRenou
Copy link
Member

I guess not! What's your npmjs handle?

@trungleduc
Copy link
Member Author

I guess not! What's your npmjs handle?

trungleduc

@martinRenou
Copy link
Member

Invitation sent!

martinRenou
martinRenou requested changes Jan 11, 2023
View reviewed changes
src/sketcher/helper.tsx Outdated Show resolved Hide resolved
src/sketcher/helper.tsx Outdated Show resolved Hide resolved
src/sketcher/sketchermodel.ts Outdated Show resolved Hide resolved
src/sketcher/sketcherwidget.tsx Outdated Show resolved Hide resolved
src/sketcher/sketcherwidget.tsx Outdated Show resolved Hide resolved
src/sketcher/sketcherwidget.tsx Outdated Show resolved Hide resolved
@trungleduc trungleduc closed this Jan 12, 2023
@trungleduc trungleduc reopened this Jan 12, 2023
@trungleduc
Copy link
Member Author

Trigger CI

@trungleduc
Copy link
Member Author

Galata please update snapshots

@trungleduc
Copy link
Member Author

Galata please update snapshots, I promise this is the last time.

@trungleduc
Copy link
Member Author

Galata please update snapshots ...

@trungleduc
Copy link
Member Author

@hbcarlos could you please take a look at this PR?

hbcarlos
hbcarlos approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@hbcarlos hbcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trungleduc!

@trungleduc
Copy link
Member Author

Galata please update snapshots

@trungleduc
Copy link
Member Author

Friendly ping @martinRenou to finish this PR.

@martinRenou
Copy link
Member

I'll have a look :)

martinRenou
martinRenou approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martinRenou martinRenou merged commit f78d426 into jupytercad:main Jan 23, 2023
@trungleduc trungleduc deleted the 2d branch May 7, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

@hbcarlos hbcarlos hbcarlos approved these changes

Assignees

@trungleduc trungleduc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trungleduc @martinRenou @hbcarlos