Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes objects tree view #75

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Fixes objects tree view #75

merged 3 commits into from
Dec 21, 2022

Conversation

hbcarlos
Copy link
Contributor

@hbcarlos hbcarlos commented Dec 20, 2022 •
edited
Loading

Fixes #48

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch hbcarlos/jupytercad/object_tree

@trungleduc
Copy link
Member

Thanks a lot @hbcarlos, could you add a screenshot test for the tree component?

@hbcarlos
Copy link
Contributor Author

This is a screencast of the new behavior.

Grabacion.de.pantalla.2022-12-21.a.las.16.20.48.mov

@trungleduc
Copy link
Member

Great! Can I push on your branch for the tree UI test?

@hbcarlos
Copy link
Contributor Author

Sure. Feel free to push.

@trungleduc
Copy link
Member

Thanks @hbcarlos !

@trungleduc trungleduc merged commit f6f15fa into jupytercad:main Dec 21, 2022
@hbcarlos hbcarlos deleted the object_tree branch December 21, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep the tree unfolded when clicking on objects
2 participants
@hbcarlos @trungleduc