Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add annotation and color API #198

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Add annotation and color API #198

merged 4 commits into from
Jun 12, 2023

Conversation

trungleduc
Copy link
Member

This PR allows users to add annotations and modify shape color with Python API

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/jupytercad/new-api

martinRenou
martinRenou requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jupytercad/notebook/cad_document.py Outdated Show resolved Hide resolved
packages/jupytercad-extension/src/mainview.tsx Outdated Show resolved Hide resolved
martinRenou
martinRenou approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 6bed941 into jupytercad:main Jun 12, 2023
@trungleduc trungleduc deleted the new-api branch January 2, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trungleduc @martinRenou