Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backend installation check #168

Merged
merged 4 commits into from
May 31, 2023
Merged

Add backend installation check #168

merged 4 commits into from
May 31, 2023

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented May 31, 2023 •
edited
Loading

Add an error message for missing FreeCAD installation.

fcmissing

caderror

Closes #47

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/jupytercad/missing-fc

@trungleduc trungleduc marked this pull request as draft May 31, 2023 14:17
@trungleduc trungleduc marked this pull request as ready for review May 31, 2023 14:40
martinRenou
martinRenou reviewed May 31, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good that we can extend it for other file types later

packages/jupytercad-extension/src/fcplugin/plugins.ts Outdated Show resolved Hide resolved
martinRenou
martinRenou approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit d610104 into jupytercad:main May 31, 2023
@trungleduc trungleduc deleted the missing-fc branch May 7, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display nice error message if freecad is not installed
2 participants
@trungleduc @martinRenou